runtime/vm/object.cc - Issue 2014913002: Tree-shaker: drop imports/exports in a way that doesn't break the vm-service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 2014913002: Tree-shaker: drop imports/exports in a way that doesn't break the vm-service. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index de74eb4dd2133ee8af70c1bb79a929d7238962bb..0d5ca5f983668e6c7c36c8c1217a7d141046c4cf 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -10245,8 +10245,8 @@ bool Library::ImportsCorelib() const {

void Library::DropDependencies() const {

- StorePointer(&raw_ptr()->imports_, Array::null());

- StorePointer(&raw_ptr()->exports_, Array::null());

+ StorePointer(&raw_ptr()->imports_, Object::empty_array().raw());

+ StorePointer(&raw_ptr()->exports_, Object::empty_array().raw());

}

« no previous file with comments | « no previous file | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »