Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2014893004: In AST-based type inference, use function elements rather than variable elements. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

In AST-based type inference, use function elements rather than variable elements. This paves the way for including closures in type inference, since closures are function elements that don't have an associated variable. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/20056c3f456609775eb5e0510cb6f84c0f3bd30b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -100 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 16 chunks +84 lines, -37 lines 0 comments Download
M pkg/analyzer/test/src/summary/linker_test.dart View 11 chunks +23 lines, -63 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-26 19:05:30 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-26 19:12:21 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-26 19:46:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
20056c3f456609775eb5e0510cb6f84c0f3bd30b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698