In AST-based type inference, use function elements rather than variable elements.

pkg/analyzer/test/src/summary/linker_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/summary/format.dart';
 import 'package:analyzer/src/summary/idl.dart';
 import 'package:analyzer/src/summary/link.dart';
 import 'package:unittest/unittest.dart';
@@ skipping 176 matching lines @@
         '''
 var x = () {};
 ''',
         path: '/a.dart');
     addBundle(bundle);
     createLinker('''
 import 'a.dart';
 var y = x;
 ''');
     LibraryElementForLink library = linker.getLibrary(linkerInputs.testDartUri);
-    expect(
-        library
-            .getContainedName('y')
-            .asTypeInferenceNode
-            .variableElement
-            .inferredType
-            .toString(),
+    expect(_getVariable(library.getContainedName('y')).inferredType.toString(),
         '() → dynamic');
   }
 
   void test_inferredType_instanceField_dynamic() {
     createLinker('''
 var x;
 class C {
   var f = x; // Inferred type: dynamic
 }
 ''');
@@ skipping 56 matching lines @@
   }
 
   void test_inferredType_staticField_dynamic() {
     createLinker('''
 dynamic x = null;
 class C {
   static var y = x;
 }
 ''');
     expect(
-        linker
-            .getLibrary(linkerInputs.testDartUri)
-            .getContainedName('C')
-            .getContainedName('y')
-            .asTypeInferenceNode
-            .variableElement
+        _getVariable(linker
+                .getLibrary(linkerInputs.testDartUri)
+                .getContainedName('C')
+                .getContainedName('y'))
             .inferredType
             .toString(),
         'dynamic');
   }
 
   void test_inferredType_topLevelVariable_dynamic() {
     createLinker('''
 dynamic x = null;
 var y = x;
 ''');
     expect(
-        linker
-            .getLibrary(linkerInputs.testDartUri)
-            .getContainedName('y')
-            .asTypeInferenceNode
-            .variableElement
+        _getVariable(linker
+                .getLibrary(linkerInputs.testDartUri)
+                .getContainedName('y'))
             .inferredType
             .toString(),
         'dynamic');
   }
 
   void test_inferredTypeFromOutsideBuildUnit_dynamic() {
     var bundle = createPackageBundle(
         '''
 var x;
 var y = x; // Inferred type: dynamic
 ''',
         path: '/a.dart');
     addBundle(bundle);
     createLinker('''
 import 'a.dart';
 var z = y; // Inferred type: dynamic
 ''');
     LibraryElementForLink library = linker.getLibrary(linkerInputs.testDartUri);
-    expect(
-        library
-            .getContainedName('z')
-            .asTypeInferenceNode
-            .variableElement
-            .inferredType
-            .toString(),
+    expect(_getVariable(library.getContainedName('z')).inferredType.toString(),
         'dynamic');
   }
 
   void test_inferredTypeFromOutsideBuildUnit_instanceField() {
     var bundle = createPackageBundle(
         '''
 class C {
   var f = 0; // Inferred type: int
 }
 ''',
         path: '/a.dart');
     addBundle(bundle);
     createLinker('''
 import 'a.dart';
 var x = new C().f; // Inferred type: int
 ''');
     LibraryElementForLink library = linker.getLibrary(linkerInputs.testDartUri);
-    expect(
-        library
-            .getContainedName('x')
-            .asTypeInferenceNode
-            .variableElement
-            .inferredType
-            .toString(),
+    expect(_getVariable(library.getContainedName('x')).inferredType.toString(),
         'int');
   }
 
   void test_inferredTypeFromOutsideBuildUnit_instanceField_toInstanceField() {
     var bundle = createPackageBundle(
         '''
 class C {
   var f = 0; // Inferred type: int
 }
 ''',
@@ skipping 20 matching lines @@
   f<T>(t) => t; // Inferred param type: T
 }
 ''',
         path: '/a.dart');
     addBundle(bundle);
     createLinker('''
 import 'a.dart';
 var x = new C().f(0); // Inferred type: int
 ''');
     LibraryElementForLink library = linker.getLibrary(linkerInputs.testDartUri);
-    expect(
-        library
-            .getContainedName('x')
-            .asTypeInferenceNode
-            .variableElement
-            .inferredType
-            .toString(),
+    expect(_getVariable(library.getContainedName('x')).inferredType.toString(),
         'int');
   }
 
   void test_inferredTypeFromOutsideBuildUnit_methodParamType_viaInheritance() {
     var bundle = createPackageBundle(
         '''
 class B {
   void f(int i) {}
 }
 class C extends B {
@@ skipping 27 matching lines @@
   f() => 1; // Inferred return type: int
 }
 ''',
         path: '/a.dart');
     addBundle(bundle);
     createLinker('''
 import 'a.dart';
 var x = new C().f(); // Inferred type: int
 ''');
     LibraryElementForLink library = linker.getLibrary(linkerInputs.testDartUri);
-    expect(
-        library
-            .getContainedName('x')
-            .asTypeInferenceNode
-            .variableElement
-            .inferredType
-            .toString(),
+    expect(_getVariable(library.getContainedName('x')).inferredType.toString(),
         'int');
   }
 
   void test_inferredTypeFromOutsideBuildUnit_methodReturnType_viaInheritance() {
     var bundle = createPackageBundle(
         '''
 class B {
   int f() => 0;
 }
 class C extends B {
@@ skipping 14 matching lines @@
     expect(cls.methods, hasLength(1));
     expect(cls.methods[0].returnType.toString(), 'int');
   }
 
   void test_inferredTypeFromOutsideBuildUnit_staticField() {
     var bundle =
         createPackageBundle('class C { static var f = 0; }', path: '/a.dart');
     addBundle(bundle);
     createLinker('import "a.dart"; var x = C.f;', path: '/b.dart');
     expect(
-        linker
-            .getLibrary(linkerInputs.testDartUri)
-            .getContainedName('x')
-            .asTypeInferenceNode
-            .variableElement
+        _getVariable(linker
+                .getLibrary(linkerInputs.testDartUri)
+                .getContainedName('x'))
             .inferredType
             .toString(),
         'int');
   }
 
   void test_inferredTypeFromOutsideBuildUnit_topLevelVariable() {
     var bundle = createPackageBundle('var a = 0;', path: '/a.dart');
     addBundle(bundle);
     createLinker('import "a.dart"; var b = a;', path: '/b.dart');
     expect(
-        linker
-            .getLibrary(linkerInputs.testDartUri)
-            .getContainedName('b')
-            .asTypeInferenceNode
-            .variableElement
+        _getVariable(linker
+                .getLibrary(linkerInputs.testDartUri)
+                .getContainedName('b'))
             .inferredType
             .toString(),
         'int');
   }
 
   void test_instantiate_param_of_param_to_bounds() {
     createLinker('''
 class C<T> {}
 class D<T extends num> {}
 final x = new C<D>();
@@ skipping 151 matching lines @@
       if (ref.kind == ReferenceKind.function) {
         ref.localIndex = 1234;
       }
     }
     addBundle(bundle);
     createLinker('''
 import 'a.dart';
 var y = x;
 ''');
     LibraryElementForLink library = linker.getLibrary(linkerInputs.testDartUri);
-    expect(
-        library
-            .getContainedName('y')
-            .asTypeInferenceNode
-            .variableElement
-            .inferredType
-            .toString(),
+    expect(_getVariable(library.getContainedName('y')).inferredType.toString(),
         'dynamic');
   }
 
   void test_multiplyInheritedExecutable_differentSignatures() {
     createLinker('''
 class B {
   void f() {}
 }
 abstract class I {
    f();
@@ skipping 122 matching lines @@
     LibraryElementForLink library = linker.getLibrary(linkerInputs.testDartUri);
     PropertyAccessorElementForLink_Variable c = library.getContainedName('c');
     expect(c.variable.initializer, isNotNull);
     PropertyAccessorElementForLink_Variable i = library.getContainedName('i');
     expect(i.variable.initializer, isNotNull);
     PropertyAccessorElementForLink_Variable j = library.getContainedName('j');
     expect(j.variable.initializer, isNull);
     PropertyAccessorElementForLink_Variable v = library.getContainedName('v');
     expect(v.variable.initializer, isNotNull);
   }
+
+  VariableElementForLink _getVariable(ReferenceableElementForLink element) {
+    return (element as PropertyAccessorElementForLink_Variable).variable;
+  }
 }