Issue 2014893003: [Extensions] Determine NativeMessaging ID solely on the browser process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2014893003: [Extensions] Determine NativeMessaging ID solely on the browser process (Closed)

Created:
4 years, 7 months ago by Devlin

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

[Extensions] Determine NativeMessaging ID solely on the browser process No need to trust renderers here. We really should do this in more places. BUG=609286 Review-Url: https://codereview.chromium.org/2006013002 Cr-Commit-Position: refs/heads/master@{#395708} (cherry picked from commit 364adab6eb1e5d928ddd18ed12c9b2a6338c4d71) Committed: https://chromium.googlesource.com/chromium/src/+/68f5ddb98b2c2f2be37902941b0a97186dfe7d91

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -39 lines)			Patch
M	chrome/browser/extensions/api/messaging/message_service.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/messaging/message_service.cc	View	5 chunks	+20 lines, -16 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_extension_message_filter.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_extension_message_filter.cc	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	extensions/browser/extension_web_contents_observer.h	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	extensions/common/extension_messages.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	extensions/renderer/runtime_custom_bindings.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download

Total messages: 2 (1 generated)

Devlin

4 years, 7 months ago (2016-05-26 18:55:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
68f5ddb98b2c2f2be37902941b0a97186dfe7d91.