Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2006013002: [Extensions] Determine NativeMessaging ID solely on the browser process (Closed)

Created:
4 years, 7 months ago by Devlin
Modified:
4 years, 7 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Determine NativeMessaging ID solely on the browser process No need to trust renderers here. We really should do this in more places. BUG=609286 Committed: https://crrev.com/364adab6eb1e5d928ddd18ed12c9b2a6338c4d71 Cr-Commit-Position: refs/heads/master@{#395708}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : ;; #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -39 lines) Patch
M chrome/browser/extensions/api/messaging/message_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 1 5 chunks +20 lines, -16 lines 0 comments Download
M chrome/browser/renderer_host/chrome_extension_message_filter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_extension_message_filter.cc View 3 chunks +1 line, -4 lines 0 comments Download
M extensions/browser/extension_web_contents_observer.h View 2 chunks +9 lines, -9 lines 0 comments Download
M extensions/common/extension_messages.h View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/renderer/runtime_custom_bindings.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Devlin
+asargent for extensions, dcheng for messages (removing a param)
4 years, 7 months ago (2016-05-24 00:51:01 UTC) #4
dcheng
ipc lgtm https://codereview.chromium.org/2006013002/diff/20001/chrome/browser/extensions/api/messaging/message_service.cc File chrome/browser/extensions/api/messaging/message_service.cc (right): https://codereview.chromium.org/2006013002/diff/20001/chrome/browser/extensions/api/messaging/message_service.cc#newcode420 chrome/browser/extensions/api/messaging/message_service.cc:420: content::WebContents::FromRenderFrameHost(source);; Nit: double semicolon here.
4 years, 7 months ago (2016-05-24 04:41:46 UTC) #5
asargent_no_longer_on_chrome
CL description typo: "soley" -> "solely" I guess we're still having the browser process trust ...
4 years, 7 months ago (2016-05-24 19:52:17 UTC) #6
Devlin
https://codereview.chromium.org/2006013002/diff/20001/chrome/browser/extensions/api/messaging/message_service.cc File chrome/browser/extensions/api/messaging/message_service.cc (right): https://codereview.chromium.org/2006013002/diff/20001/chrome/browser/extensions/api/messaging/message_service.cc#newcode420 chrome/browser/extensions/api/messaging/message_service.cc:420: content::WebContents::FromRenderFrameHost(source);; On 2016/05/24 04:41:46, dcheng wrote: > Nit: double ...
4 years, 7 months ago (2016-05-24 21:59:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006013002/40001
4 years, 7 months ago (2016-05-24 22:00:02 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-24 22:18:43 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 22:20:18 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/364adab6eb1e5d928ddd18ed12c9b2a6338c4d71
Cr-Commit-Position: refs/heads/master@{#395708}

Powered by Google App Engine
This is Rietveld 408576698