[Extensions] Determine NativeMessaging ID solely on the browser process

[Extensions] Determine NativeMessaging ID solely on the browser process

No need to trust renderers here. We really should do this in more places.

BUG=609286
Committed: https://crrev.com/364adab6eb1e5d928ddd18ed12c9b2a6338c4d71
Cr-Commit-Position: refs/heads/master@{#395708}

[Devlin, 2016-05-24 00:49:30]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-05-24 00:50:21]

Description was changed from

==========
test

BUG=
==========

to

==========
[Extensions] Determine NativeMessaging ID soley on the browser process

No need to trust renderers here. We really should do this in more places.

BUG=609286
==========

[Devlin, 2016-05-24 00:51:01]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org, dcheng@chromium.org

[Devlin, 2016-05-24 00:51:01]

+asargent for extensions, dcheng for messages (removing a param)

[dcheng, 2016-05-24 04:41:46]

ipc lgtm

https://codereview.chromium.org/2006013002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/messaging/message_service.cc (right):

https://codereview.chromium.org/2006013002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/messaging/message_service.cc:420:
content::WebContents::FromRenderFrameHost(source);;
Nit: double semicolon here.

[asargent_no_longer_on_chrome, 2016-05-24 19:52:17]

CL description typo: "soley" -> "solely"

I guess we're still having the browser process trust the value for the routing
id that comes in the IPC, but I guess those are much less easily guessed/spoofed
by a compromised renderer (and the process id we use doesn't come from the
renderer, it comes from the RenderProcessHost at the time we setup the
ChromeExtensionMessageFilter)

Anyhow, lgtm

[Devlin, 2016-05-24 19:56:37]

Description was changed from

==========
[Extensions] Determine NativeMessaging ID soley on the browser process

No need to trust renderers here. We really should do this in more places.

BUG=609286
==========

to

==========
[Extensions] Determine NativeMessaging ID solely on the browser process

No need to trust renderers here. We really should do this in more places.

BUG=609286
==========

[Devlin, 2016-05-24 21:59:09]

https://codereview.chromium.org/2006013002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/messaging/message_service.cc (right):

https://codereview.chromium.org/2006013002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/messaging/message_service.cc:420:
content::WebContents::FromRenderFrameHost(source);;
On 2016/05/24 04:41:46, dcheng wrote:
> Nit: double semicolon here.

Done.

[Devlin, 2016-05-24 21:59:12]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-05-24 21:59:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2006013002/#ps40001
(title: ";;")

[commit-bot: I haz the power, 2016-05-24 22:00:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006013002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006013002/40001

[commit-bot: I haz the power, 2016-05-24 22:18:43]

Description was changed from

==========
[Extensions] Determine NativeMessaging ID solely on the browser process

No need to trust renderers here. We really should do this in more places.

BUG=609286
==========

to

==========
[Extensions] Determine NativeMessaging ID solely on the browser process

No need to trust renderers here. We really should do this in more places.

BUG=609286
==========

[commit-bot: I haz the power, 2016-05-24 22:18:43]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-24 22:20:17]

Description was changed from

==========
[Extensions] Determine NativeMessaging ID solely on the browser process

No need to trust renderers here. We really should do this in more places.

BUG=609286
==========

to

==========
[Extensions] Determine NativeMessaging ID solely on the browser process

No need to trust renderers here. We really should do this in more places.

BUG=609286

Committed: https://crrev.com/364adab6eb1e5d928ddd18ed12c9b2a6338c4d71
Cr-Commit-Position: refs/heads/master@{#395708}
==========

[commit-bot: I haz the power, 2016-05-24 22:20:18]

Patchset 2 (id:??) landed as
https://crrev.com/364adab6eb1e5d928ddd18ed12c9b2a6338c4d71
Cr-Commit-Position: refs/heads/master@{#395708}