Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2014883002: Remove dead code: webkitpy.layout_tests.port.config. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, ojan
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead code: webkitpy.layout_tests.port.config. Committed: https://crrev.com/12931ee022d51d7007ee856af86bb9c6eab2eb6b Cr-Commit-Position: refs/heads/master@{#397053}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -80 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 3 chunks +1 line, -3 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/config.py View 1 chunk +0 lines, -73 lines 1 comment Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
qyearsley
This CL is not urgent. https://codereview.chromium.org/2014883002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/config.py File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/config.py (left): https://codereview.chromium.org/2014883002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/config.py#oldcode29 third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/config.py:29: # FIXME: Remove this ...
4 years, 7 months ago (2016-05-26 16:55:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014883002/1
4 years, 6 months ago (2016-05-28 16:26:25 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-28 17:31:59 UTC) #6
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-01 00:10:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014883002/1
4 years, 6 months ago (2016-06-01 03:12:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 04:20:00 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 04:22:38 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/12931ee022d51d7007ee856af86bb9c6eab2eb6b
Cr-Commit-Position: refs/heads/master@{#397053}

Powered by Google App Engine
This is Rietveld 408576698