third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py - Issue 2014883002: Remove dead code: webkitpy.layout_tests.port.config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

Issue 2014883002: Remove dead code: webkitpy.layout_tests.port.config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/config.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/config.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

index 34bf83faec2f942f2e0dfe894842a564b5e2c4fd..415635fb0ea43973876cff5d27e1fb5e8c9030ce 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

@@ -45,7 +45,6 @@ class DriverTest(unittest.TestCase):

def make_port(self):

port = Port(MockSystemHost(), 'test', MockOptions(configuration='Release'))

- port._config.build_directory = lambda configuration: '/mock-checkout/out/' + configuration

return port

def _assert_wrapper(self, wrapper_string, expected_wrapper):

@@ -132,7 +131,6 @@ class DriverTest(unittest.TestCase):

def test_no_timeout(self):

port = TestWebKitPort()

- port._config.build_directory = lambda configuration: '/mock-checkout/out/' + configuration

driver = Driver(port, 0, pixel_tests=True, no_timeout=True)

cmd_line = driver.cmd_line(True, [])

self.assertEqual(cmd_line[0], '/mock-checkout/out/Release/content_shell')