Remove a DCHECK in BitmapUploader which causes crash in some unittests

Remove a DCHECK in BitmapUploader which causes crash in some unittests

In some unittests, the BitmapUploader will be constructed, but it will never be used. So the DCHECK causes unnecessary crashes for those unittests, so remove it.

BUG=614911

[Peng, 2016-05-26 15:34:25]

Description was changed from

==========
Remove a DCHECK in BitmapUploader which causes crash in some unittests

BUG=614911
==========

to

==========
Remove a DCHECK in BitmapUploader which causes crash in some unittests

In some unittests, the BitmapUploader will be constructed, but it will never be
used. So the DCHECK causes unnecessary crashes for those unittests, so remove
it.

BUG=614911
==========

[Peng, 2016-05-26 15:35:00]

penghuang@chromium.org changed reviewers:
+ sadrul@chromium.org

[Peng, 2016-05-26 15:35:01]

Hi Sadrul, PTAL. Thanks.

[sadrul, 2016-05-26 15:41:35]

https://codereview.chromium.org/2014853002/diff/1/components/bitmap_uploader/...
File components/bitmap_uploader/bitmap_uploader.cc (right):

https://codereview.chromium.org/2014853002/diff/1/components/bitmap_uploader/...
components/bitmap_uploader/bitmap_uploader.cc:53: gles2_context_.reset();
Can you add a DCHECK here that if Initialize() returns false, then that's
because gpu_service_ had an error of some sort, i.e. install a
set_connection_error_handler on |gpu_service_|, and DCHECK that the handler was
called if Initialize() returned false?

[Peng, 2016-05-30 14:04:26]

https://codereview.chromium.org/2014853002/diff/1/components/bitmap_uploader/...
File components/bitmap_uploader/bitmap_uploader.cc (right):

https://codereview.chromium.org/2014853002/diff/1/components/bitmap_uploader/...
components/bitmap_uploader/bitmap_uploader.cc:53: gles2_context_.reset();
On 2016/05/26 15:41:35, sadrul wrote:
> Can you add a DCHECK here that if Initialize() returns false, then that's
> because gpu_service_ had an error of some sort, i.e. install a
> set_connection_error_handler on |gpu_service_|, and DCHECK that the handler
was
> called if Initialize() returned false?

gpu_service_.encountered_error() is not true at here.
But if command_buffer_.encountered_error() is true at
https://code.google.com/p/chromium/codesearch#chromium/src/components/mus/pub...
.

Any thought?