Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: components/bitmap_uploader/bitmap_uploader.cc

Issue 2014853002: Remove a DCHECK in BitmapUploader which causes crash in some unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bitmap_uploader/bitmap_uploader.cc
diff --git a/components/bitmap_uploader/bitmap_uploader.cc b/components/bitmap_uploader/bitmap_uploader.cc
index 5c255dbf2f8a2b68dc45626b5ed808b730b0b526..115053f83d29023d3f7a224935e6358075b9484e 100644
--- a/components/bitmap_uploader/bitmap_uploader.cc
+++ b/components/bitmap_uploader/bitmap_uploader.cc
@@ -49,7 +49,8 @@ void BitmapUploader::Init(shell::Connector* connector) {
gpu_service_->CreateOffscreenGLES2Context(GetProxy(&gles2_client));
gles2_context_.reset(new mus::GLES2Context(
std::vector<int32_t>(), gles2_client.PassInterface().PassHandle()));
- DCHECK(gles2_context_->Initialize());
+ if (!gles2_context_->Initialize())
+ gles2_context_.reset();
sadrul 2016/05/26 15:41:35 Can you add a DCHECK here that if Initialize() ret
Peng 2016/05/30 14:04:25 gpu_service_.encountered_error() is not true at he
}
// Sets the color which is RGBA.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698