content/public/browser/resource_dispatcher_host.h - Issue 2014803002: Move DownloadControllerAndroid from content/ to chrome/

Unified Diff: content/public/browser/resource_dispatcher_host.h

Issue 2014803002: Move DownloadControllerAndroid from content/ to chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved DownloadControllerAndroid(Impl) to chrome/ Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content_public/browser/DownloadInfo.java ('K') | « content/public/browser/android/download_controller_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/resource_dispatcher_host.h

diff --git a/content/public/browser/resource_dispatcher_host.h b/content/public/browser/resource_dispatcher_host.h

index 3bdd0cae132f4bb9dbd61c3066db169bf5e1bbf0..1ad50bb80322fbfd4f6f2c27ad34e97123607140 100644

--- a/content/public/browser/resource_dispatcher_host.h

+++ b/content/public/browser/resource_dispatcher_host.h

@@ -11,6 +11,7 @@

#include "base/callback_forward.h"

#include "content/common/content_export.h"

+#include "net/url_request/url_request.h"

namespace net {

class URLRequest;

@@ -18,6 +19,7 @@ class URLRequest;

namespace content {

+class GlobalRequestID;

class DownloadItem;

class ResourceContext;

class ResourceDispatcherHostDelegate;

@@ -51,6 +53,10 @@ class CONTENT_EXPORT ResourceDispatcherHost {

// Clears the ResourceDispatcherHostLoginDelegate associated with the request.

virtual void ClearLoginDelegateForRequest(net::URLRequest* request) = 0;

+ // Retrieves a net::URLRequest. Must be called from the IO thread.

+ virtual net::URLRequest* GetURLRequest(

+ const content::GlobalRequestID& request_id) = 0;

no sievers 2016/06/07 21:35:23 @Min: you think it's straightforward to maybe remo

Jinsuk Kim 2016/06/08 06:29:08 URLRequest instance is necessary not only for cook

no sievers 2016/06/08 18:28:22 It's actually also obsolete with kSystemDownloadMa

qinmin 2016/06/08 18:31:37 Due to some user feedback, we are not yet deprecat

protected:

virtual ~ResourceDispatcherHost() {}

};