Move DownloadControllerAndroid from content/ to chrome/

content/public/browser/resource_dispatcher_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RESOURCE_DISPATCHER_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_RESOURCE_DISPATCHER_HOST_H_
 
 #include <stdint.h>
 
 #include <memory>
 
 #include "base/callback_forward.h"
 #include "content/common/content_export.h"
+#include "net/url_request/url_request.h"
 
 namespace net {
 class URLRequest;
 }
 
 namespace content {
 
+class GlobalRequestID;
 class DownloadItem;
 class ResourceContext;
 class ResourceDispatcherHostDelegate;
 struct DownloadSaveInfo;
 struct Referrer;
 class RenderFrameHost;
 
 class CONTENT_EXPORT ResourceDispatcherHost {
  public:
   // Returns the singleton instance of the ResourceDispatcherHost.
@@ skipping 13 matching lines @@
   // delegate have a longer lifetime than the ResourceDispatcherHost.
   virtual void SetDelegate(ResourceDispatcherHostDelegate* delegate) = 0;
 
   // Controls whether third-party sub-content can pop-up HTTP basic auth
   // dialog boxes.
   virtual void SetAllowCrossOriginAuthPrompt(bool value) = 0;
 
   // Clears the ResourceDispatcherHostLoginDelegate associated with the request.
   virtual void ClearLoginDelegateForRequest(net::URLRequest* request) = 0;
 
+  // Retrieves a net::URLRequest.  Must be called from the IO thread.
+  virtual net::URLRequest* GetURLRequest(
+      const content::GlobalRequestID& request_id) = 0;

[no sievers, 2016/06/07 21:35:23]

@Min: you think it's straightforward to maybe remove the need for the cookies in
a prerequisite patch so we don't have to expose this?

[Jinsuk Kim, 2016/06/08 06:29:08]

URLRequest instance is necessary not only for cookie but also for building
DownloadInfo used in download_controller.cc.

[no sievers, 2016/06/08 18:28:22]

It's actually also obsolete with kSystemDownloadManager. But you are right and
the removal of all that code shouldn't be in this patch.

I'm wondering if the PrepareDownloadInfo() code can move up to the call site
which is  InterceptDownloadResourceThrottle::ProcessDownloadRequest(). That
class actually gets the URLRequest in its contructor.

[qinmin, 2016/06/08 18:31:37]

Due to some user feedback, we are not yet deprecating kSystemDownloadManager, so
the cookies are still needed

+
  protected:
   virtual ~ResourceDispatcherHost() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RESOURCE_DISPATCHER_HOST_H_