Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 20148002: Mark test BackgroundFilterBlurOutsets as fuzzy on all platforms, and add the new baseline from the … (Closed)

Created:
7 years, 5 months ago by Stephen White
Modified:
7 years, 5 months ago
Reviewers:
danakj, robertphilips
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Mark test BackgroundFilterBlurOutsets as fuzzy on all platforms, and add the new baseline from the upcoming skia roll. R=danakj@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M cc/test/data/background_filter_blur_outsets.png View Binary file 0 comments Download
M cc/trees/layer_tree_host_pixeltest_filters.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen White
PTAL. Image differs only in the LSB, AFAIK.
7 years, 5 months ago (2013-07-24 21:22:59 UTC) #1
danakj
LGTM
7 years, 5 months ago (2013-07-24 21:23:59 UTC) #2
Stephen White
On 2013/07/24 21:22:59, Stephen White wrote: > PTAL. Image differs only in the LSB, AFAIK. ...
7 years, 5 months ago (2013-07-24 21:28:14 UTC) #3
robertphillips
On 2013/07/24 21:28:14, Stephen White wrote: > On 2013/07/24 21:22:59, Stephen White wrote: > > ...
7 years, 5 months ago (2013-07-24 23:41:29 UTC) #4
Stephen White
Committed patchset #1 manually as r213573 (presubmit successful).
7 years, 5 months ago (2013-07-25 01:44:36 UTC) #5
Stephen White
7 years, 5 months ago (2013-07-25 01:51:48 UTC) #6
Message was sent while issue was closed.
On 2013/07/24 23:41:29, robertphillips wrote:
> On 2013/07/24 21:28:14, Stephen White wrote:
> > On 2013/07/24 21:22:59, Stephen White wrote:
> > > PTAL. Image differs only in the LSB, AFAIK.
> > 
> > robertphilips: if you land Skia rolls via dcommit, you could also just land
> the
> > PNG with the roll. Let me know what you prefer.
> 
> I not having any luck uploading a patch with the .png so can we land the
fuzzed
> version, etc. etc. first?

Done.

Powered by Google App Engine
This is Rietveld 408576698