Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4884)

Unified Diff: cc/trees/layer_tree_host_pixeltest_filters.cc

Issue 20148002: Mark test BackgroundFilterBlurOutsets as fuzzy on all platforms, and add the new baseline from the … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/data/background_filter_blur_outsets.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_pixeltest_filters.cc
diff --git a/cc/trees/layer_tree_host_pixeltest_filters.cc b/cc/trees/layer_tree_host_pixeltest_filters.cc
index f9125b91f02a2c499cdc3310a8eca0af15aa38ef..da42f4cd4765e0a23322c241c4fdea94e42c720d 100644
--- a/cc/trees/layer_tree_host_pixeltest_filters.cc
+++ b/cc/trees/layer_tree_host_pixeltest_filters.cc
@@ -71,7 +71,10 @@ TEST_F(LayerTreeHostFiltersPixelTest, BackgroundFilterBlurOutsets) {
filters.Append(FilterOperation::CreateBlurFilter(5.f));
blur->SetBackgroundFilters(filters);
-#if defined(OS_WIN)
+// TODO(senorblanco): Mark this test fuzzy on all platforms for now, until
+// the next Skia roll. Then uncomment the #if below, and put it back to only
+// being fuzzy on Win.
+// #if defined(OS_WIN)
// Windows has 2250 pixels off by at most 2: crbug.com/259922
float percentage_pixels_large_error = 5.625f; // 2250px / (200*200)
float percentage_pixels_small_error = 0.0f;
@@ -85,7 +88,7 @@ TEST_F(LayerTreeHostFiltersPixelTest, BackgroundFilterBlurOutsets) {
average_error_allowed_in_bad_pixels,
large_error_allowed,
small_error_allowed));
-#endif
+// #endif
RunPixelTest(GL_WITH_BITMAP,
background,
« no previous file with comments | « cc/test/data/background_filter_blur_outsets.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698