Removing parsing of text from pasteboard.

third_party/mozilla/NSPasteboard+Utils.h

Index: third_party/mozilla/NSPasteboard+Utils.h
diff --git a/third_party/mozilla/NSPasteboard+Utils.h b/third_party/mozilla/NSPasteboard+Utils.h
index 58f0d66ba71f9fa64b18fa81f95b5f9b92732a8f..cf3d79c8f5c3106150247d9718164a2c6821cf89 100644
--- a/third_party/mozilla/NSPasteboard+Utils.h
+++ b/third_party/mozilla/NSPasteboard+Utils.h
@@ -54,9 +54,10 @@ MOZILLA_EXPORT extern NSString* const kWebURLsWithTitlesPboardType;
 
 - (void) setURLs:(NSArray*)inUrls withTitles:(NSArray*)inTitles;
 - (void) getURLs:(NSArray**)outUrls
-    andTitles:(NSArray**)outTitles
-    convertingFilenames:(BOOL)convertFilenames;
-- (BOOL) containsURLData;
+              andTitles:(NSArray**)outTitles
+    convertingFilenames:(BOOL)convertFilenames
+       convertTextToURL:(BOOL)convertTextToURL;

[Avi (use Gerrit), 2016/06/02 18:08:02]

convertingTextToURL to match the previous selector section.

+- (BOOL) containsURLData:(BOOL)convertTextToURL;

[Avi (use Gerrit), 2016/06/02 18:08:02]

This doesn't work. Your code acknowledges that by having a comment everywhere:

[pasteboard containsURLData:/*convertTextToURL*/ YES]

which is awkward and bad. You need to rename this method so that the call is
self-documenting.

If I had to come up with something, I'd say

- (BOOL) containsURLDataConvertingTextToURL:(BOOL)convertingTextToURL

so that calls would be:

[pasteboard containsURLDataConvertingTextToURL:YES]

I'm open to a better name (that is the best I could come up with in two minutes)
but what you have now isn't good.

 
 @end