Removing parsing of text from pasteboard.

third_party/mozilla/NSPasteboard+Utils.h

 /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
  * 1.1 (the "License"); you may not use this file except in compliance with
  * the License. You may obtain a copy of the License at
  * http://www.mozilla.org/MPL/
  *
  * Software distributed under the License is distributed on an "AS IS" basis,
  * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
@@ skipping 36 matching lines @@
 MOZILLA_EXPORT extern NSString* const kCaminoBookmarkListPBoardType;
 MOZILLA_EXPORT extern NSString* const kWebURLsWithTitlesPboardType;
 
 @interface NSPasteboard(ChimeraPasteboardURLUtils)
 
 - (int) declareURLPasteboardWithAdditionalTypes:(NSArray*)additionalTypes owner:(id)newOwner;
 - (void) setDataForURL:(NSString*)url title:(NSString*)title;
 
 - (void) setURLs:(NSArray*)inUrls withTitles:(NSArray*)inTitles;
 - (void) getURLs:(NSArray**)outUrls
-    andTitles:(NSArray**)outTitles
-    convertingFilenames:(BOOL)convertFilenames;
-- (BOOL) containsURLData;
+              andTitles:(NSArray**)outTitles
+    convertingFilenames:(BOOL)convertFilenames
+       convertTextToURL:(BOOL)convertTextToURL;

[Avi (use Gerrit), 2016/06/02 18:08:02]

convertingTextToURL to match the previous selector section.

+- (BOOL) containsURLData:(BOOL)convertTextToURL;

[Avi (use Gerrit), 2016/06/02 18:08:02]

This doesn't work. Your code acknowledges that by having a comment everywhere:

[pasteboard containsURLData:/*convertTextToURL*/ YES]

which is awkward and bad. You need to rename this method so that the call is
self-documenting.

If I had to come up with something, I'd say

- (BOOL) containsURLDataConvertingTextToURL:(BOOL)convertingTextToURL

so that calls would be:

[pasteboard containsURLDataConvertingTextToURL:YES]

I'm open to a better name (that is the best I could come up with in two minutes)
but what you have now isn't good.

 
 @end
 
 @interface NSPasteboard(ChromiumHTMLUtils)
 
 // Returns the HTML converted from RTF data on the pasteboard. If there is
 // none, returns an empty string.
 - (NSString*)htmlFromRtf;
 
 @end