Chromium Code Reviews Chromium Code Reviews
Issue 2014473002:
bluetooth: Web Bluetooth can filter by empty device names, doesn't leak MACs. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@bt-GetNameOrEmpty-| Index: third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-missing-device.html |
| diff --git a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-missing-device.html b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-missing-device.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..f32057a01bd3561db43bf5bf101329311a9e9f51 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-missing-device.html |
| @@ -0,0 +1,48 @@ |
| +<!DOCTYPE html> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| +<script src="../../resources/bluetooth/bluetooth-helpers.js"></script> |
| +<script> |
| +'use strict'; |
|
ortuno
2016/07/31 18:00:06
Please put each test in a separate file.
scheib
2016/08/02 03:24:34
Done.
|
| +promise_test(() => { |
| + return setBluetoothFakeAdapter('NoNameHeartRateAdapter') |
| + .then(() => requestDeviceWithKeyDown({ |
| + filters: [{services: ['heart_rate']}], |
| + optionalServices: ['generic_access']})) |
|
ortuno
2016/07/31 18:00:06
nit: No need for optionalServices.
scheib
2016/08/02 03:24:34
Done.
|
| + .then(device => { |
| + assert_equals(device.name, null); |
| + }) |
| +}, 'An unnamed device can be obtained by advertised service UUID.'); |
| + |
| +promise_test(t => { |
| + return setBluetoothFakeAdapter('NoNameHeartRateAdapter') |
| + .then(() => promise_rejects( |
| + t, 'NotFoundError', requestDeviceWithKeyDown({ |
| + filters: [{ |
| + name: '', |
| + services: ['heart_rate'] |
| + }]}))); |
| +}, 'An unnamed device can not be obtained by empty name filter.'); |
| + |
| +promise_test(t => { |
| + return setBluetoothFakeAdapter('NoNameHeartRateAdapter') |
| + .then(() => promise_rejects( |
| + t, 'NotFoundError', requestDeviceWithKeyDown({ |
| + filters: [{ |
| + name: 'a', |
| + services: ['heart_rate'] |
| + }]}))); |
| +}, 'An unnamed device can not be obtained by name filter.'); |
| + |
| +promise_test(t => { |
| + return setBluetoothFakeAdapter('NoNameHeartRateAdapter') |
| + .then(() => promise_rejects( |
| + t, 'NotFoundError', requestDeviceWithKeyDown({ |
| + filters: [{ |
| + namePrefix: 'a', |
| + services: ['heart_rate'] |
| + }]}))); |
| +}, 'An unnamed device can not be obtained by empty namePrefix filter.'); |
|
ortuno
2016/07/31 18:00:05
well it's not really an empty namePrefix ;)
scheib
2016/08/02 03:24:34
Done.
|
| + |
| +</script> |
| + |
