Chromium Code Reviews Chromium Code Reviews
Issue 2014473002:
bluetooth: Web Bluetooth can filter by empty device names, doesn't leak MACs. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@bt-GetNameOrEmpty-| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <!DOCTYPE html> | |
| 2 <script src="../../resources/testharness.js"></script> | |
| 3 <script src="../../resources/testharnessreport.js"></script> | |
| 4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script> | |
| 5 <script> | |
| 6 'use strict'; | |
|
ortuno
2016/07/31 18:00:06
Please put each test in a separate file.
scheib
2016/08/02 03:24:34
Done.
| |
| 7 promise_test(() => { | |
| 8 return setBluetoothFakeAdapter('NoNameHeartRateAdapter') | |
| 9 .then(() => requestDeviceWithKeyDown({ | |
| 10 filters: [{services: ['heart_rate']}], | |
| 11 optionalServices: ['generic_access']})) | |
|
ortuno
2016/07/31 18:00:06
nit: No need for optionalServices.
scheib
2016/08/02 03:24:34
Done.
| |
| 12 .then(device => { | |
| 13 assert_equals(device.name, null); | |
| 14 }) | |
| 15 }, 'An unnamed device can be obtained by advertised service UUID.'); | |
| 16 | |
| 17 promise_test(t => { | |
| 18 return setBluetoothFakeAdapter('NoNameHeartRateAdapter') | |
| 19 .then(() => promise_rejects( | |
| 20 t, 'NotFoundError', requestDeviceWithKeyDown({ | |
| 21 filters: [{ | |
| 22 name: '', | |
| 23 services: ['heart_rate'] | |
| 24 }]}))); | |
| 25 }, 'An unnamed device can not be obtained by empty name filter.'); | |
| 26 | |
| 27 promise_test(t => { | |
| 28 return setBluetoothFakeAdapter('NoNameHeartRateAdapter') | |
| 29 .then(() => promise_rejects( | |
| 30 t, 'NotFoundError', requestDeviceWithKeyDown({ | |
| 31 filters: [{ | |
| 32 name: 'a', | |
| 33 services: ['heart_rate'] | |
| 34 }]}))); | |
| 35 }, 'An unnamed device can not be obtained by name filter.'); | |
| 36 | |
| 37 promise_test(t => { | |
| 38 return setBluetoothFakeAdapter('NoNameHeartRateAdapter') | |
| 39 .then(() => promise_rejects( | |
| 40 t, 'NotFoundError', requestDeviceWithKeyDown({ | |
| 41 filters: [{ | |
| 42 namePrefix: 'a', | |
| 43 services: ['heart_rate'] | |
| 44 }]}))); | |
| 45 }, 'An unnamed device can not be obtained by empty namePrefix filter.'); | |
|
ortuno
2016/07/31 18:00:05
well it's not really an empty namePrefix ;)
scheib
2016/08/02 03:24:34
Done.
| |
| 46 | |
| 47 </script> | |
| 48 | |
| OLD | NEW |
