Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2635)

Unified Diff: android_webview/renderer/aw_message_port_client.cc

Issue 2014323002: Use std::unique_ptr<base::Value> in V8ValueConverter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/extensions/cast_streaming_native_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/renderer/aw_message_port_client.cc
diff --git a/android_webview/renderer/aw_message_port_client.cc b/android_webview/renderer/aw_message_port_client.cc
index 62def3d57240f792c1f486aa258b471ca8aae901..52e6ee72adeb4f7073b9144919ea4835396c0af9 100644
--- a/android_webview/renderer/aw_message_port_client.cc
+++ b/android_webview/renderer/aw_message_port_client.cc
@@ -4,6 +4,9 @@
#include "android_webview/renderer/aw_message_port_client.h"
+#include <memory>
+#include <utility>
+
#include "android_webview/common/aw_message_port_messages.h"
#include "content/public/child/v8_value_converter.h"
#include "content/public/renderer/render_frame.h"
@@ -62,9 +65,9 @@ void AwMessagePortClient::OnWebToAppMessage(
converter->SetDateAllowed(true);
converter->SetRegExpAllowed(true);
base::ListValue result;
- base::Value* value = converter->FromV8Value(v8value, context);
+ std::unique_ptr<base::Value> value = converter->FromV8Value(v8value, context);
if (value) {
- result.Append(value);
+ result.Append(std::move(value));
}
Send(new AwMessagePortHostMsg_ConvertedWebToAppMessage(
« no previous file with comments | « no previous file | chrome/renderer/extensions/cast_streaming_native_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698