Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 2014303002: Upstream: Pass Bundle to WebApkServiceImpl constructor (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
Xi Han
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream: Pass Bundle to WebApkServiceImpl constructor Passing a Bundle with arguments for the WebApkServiceImpl constructor enables updating the parameters which are passed to the constructor without changing the constructor's signature. BUG=609122 Committed: https://crrev.com/7c009934d42f091ada0794771312b5d364e797df Cr-Commit-Position: refs/heads/master@{#396649}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/WebApkServiceImpl.java View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java View 1 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pkotwicz
Xi can you please take a look?
4 years, 7 months ago (2016-05-26 18:25:11 UTC) #3
pkotwicz
Xi can you please take a look? This CL depends on https://codereview.chromium.org/2009423002/
4 years, 7 months ago (2016-05-26 18:26:12 UTC) #4
Xi Han
lgtm
4 years, 6 months ago (2016-05-27 14:53:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014303002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014303002/40001
4 years, 6 months ago (2016-05-28 22:14:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-05-28 22:54:42 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-28 22:55:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c009934d42f091ada0794771312b5d364e797df
Cr-Commit-Position: refs/heads/master@{#396649}

Powered by Google App Engine
This is Rietveld 408576698