Upstream: Version WebAPK runtime library

Upstream: Version WebAPK runtime library

This CL adds a version number to the runtime library. When the version number
is incremented the runtime library is re-extracted from the Chrome APK

BUG=524670
Committed: https://crrev.com/03dc5439b5b48ce387837e32fee399a925b5bdad
Cr-Commit-Position: refs/heads/master@{#396978}

[pkotwicz, 2016-05-26 13:10:56]

Description was changed from

==========
ABCD

BUG=
==========

to

==========
Version WebAPK runtime library

This CL adds a version number to the runtime library. When the version number
is incremented the runtime library is re-extracted from the Chrome APK

BUG=524670
==========

[pkotwicz, 2016-05-26 14:49:53]

Description was changed from

==========
Version WebAPK runtime library

This CL adds a version number to the runtime library. When the version number
is incremented the runtime library is re-extracted from the Chrome APK

BUG=524670
==========

to

==========
Upstream: Version WebAPK runtime library

This CL adds a version number to the runtime library. When the version number
is incremented the runtime library is re-extracted from the Chrome APK

BUG=524670
==========

[pkotwicz, 2016-05-26 14:49:53]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2016-05-26 14:50:25]

Xi, can you please take a look?

[Xi Han, 2016-05-26 21:40:23]

https://codereview.chromium.org/2009423002/diff/1/chrome/android/webapk/libs/...
File
chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkUtils.java
(right):

https://codereview.chromium.org/2009423002/diff/1/chrome/android/webapk/libs/...
chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkUtils.java:68:
return "web_apk" + version + ".dex";
I think we need to change it to "webapk".

https://codereview.chromium.org/2009423002/diff/1/chrome/android/webapk/libs/...
File chrome/android/webapk/libs/runtime_library/BUILD.gn (right):

https://codereview.chromium.org/2009423002/diff/1/chrome/android/webapk/libs/...
chrome/android/webapk/libs/runtime_library/BUILD.gn:32:
write_file("$target_gen_dir/web_apk_dex_version.txt", runtime_library_version)
Please change to webapk_dex_version.txt

https://codereview.chromium.org/2009423002/diff/1/chrome/android/webapk/libs/...
chrome/android/webapk/libs/runtime_library/BUILD.gn:36:
"$target_gen_dir/web_apk_dex_version.txt",
webapk_dex_version.txt

https://codereview.chromium.org/2009423002/diff/1/chrome/android/webapk/shell...
File
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java
(right):

https://codereview.chromium.org/2009423002/diff/1/chrome/android/webapk/shell...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java:38:
private static final String PREF_FILE_NAME = "WEBAPK_PREFS";
I am not sure whether use "WEBAPK_PREFS" or "webapk.prefs"? It seems lower cases
are used more.

https://codereview.chromium.org/2009423002/diff/1/chrome/android/webapk/shell...
chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkServiceFactory.java:151:
int runtimeDexVersion = readAssetContentsToInt(remoteContext,
"web_apk_dex_version.txt");
webapk_dex_version.txt.

[pkotwicz, 2016-05-27 20:26:37]

Xi, can you please take another look?

[Xi Han, 2016-05-27 21:34:46]

lgtm

[pkotwicz, 2016-05-28 22:15:04]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2016-05-28 22:15:05]

dfalcantara@ can you please take a look at the changes in chrome/android/java ?

[gone, 2016-05-31 18:09:09]

chrome/android/java lgtm % nits

https://codereview.chromium.org/2009423002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
(right):

https://codereview.chromium.org/2009423002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java:247: //
Forces the WebAPK runtime dex to be extracted each time that Chrome is started.
Follow the javadoc pattern everything else uses above.

https://codereview.chromium.org/2009423002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkVersionManager.java
(right):

https://codereview.chromium.org/2009423002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkVersionManager.java:44:
ChromeSwitches.ALWAYS_EXTRACT_WEBAPK_RUNTIME_DEX_ON_STARTUP)
Something about the indentation here is really, really weird.

[pkotwicz, 2016-05-31 21:39:05]

https://codereview.chromium.org/2009423002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkVersionManager.java
(right):

https://codereview.chromium.org/2009423002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkVersionManager.java:44:
ChromeSwitches.ALWAYS_EXTRACT_WEBAPK_RUNTIME_DEX_ON_STARTUP)
This is how clang-format formats the line
https://g3doc.corp.google.com/devtools/cymbal/tools/g3doc/clang-format/index....

[pkotwicz, 2016-05-31 21:49:01]

Patchset #3 (id:40001) has been deleted

[gone, 2016-05-31 21:49:39]

https://codereview.chromium.org/2009423002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkVersionManager.java
(right):

https://codereview.chromium.org/2009423002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkVersionManager.java:44:
ChromeSwitches.ALWAYS_EXTRACT_WEBAPK_RUNTIME_DEX_ON_STARTUP)
On 2016/05/31 21:39:05, pkotwicz wrote:
> This is how clang-format formats the line
>
https://g3doc.corp.google.com/devtools/cymbal/tools/g3doc/clang-format/index....

Clang consistently screws up Java code.

[pkotwicz, 2016-05-31 21:53:49]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-05-31 21:53:50]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2009423002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-05-31 21:54:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2009423002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2009423002/60001

[gone, 2016-05-31 21:55:02]

Are you ignoring the nit then?

[commit-bot: I haz the power, 2016-05-31 23:44:21]

Description was changed from

==========
Upstream: Version WebAPK runtime library

This CL adds a version number to the runtime library. When the version number
is incremented the runtime library is re-extracted from the Chrome APK

BUG=524670
==========

to

==========
Upstream: Version WebAPK runtime library

This CL adds a version number to the runtime library. When the version number
is incremented the runtime library is re-extracted from the Chrome APK

BUG=524670
==========

[commit-bot: I haz the power, 2016-05-31 23:44:22]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-05-31 23:46:04]

Description was changed from

==========
Upstream: Version WebAPK runtime library

This CL adds a version number to the runtime library. When the version number
is incremented the runtime library is re-extracted from the Chrome APK

BUG=524670
==========

to

==========
Upstream: Version WebAPK runtime library

This CL adds a version number to the runtime library. When the version number
is incremented the runtime library is re-extracted from the Chrome APK

BUG=524670

Committed: https://crrev.com/03dc5439b5b48ce387837e32fee399a925b5bdad
Cr-Commit-Position: refs/heads/master@{#396978}
==========

[commit-bot: I haz the power, 2016-05-31 23:46:05]

Patchset 3 (id:??) landed as
https://crrev.com/03dc5439b5b48ce387837e32fee399a925b5bdad
Cr-Commit-Position: refs/heads/master@{#396978}