Implement cc::SurfaceId StructTraits

Implement cc::SurfaceId StructTraits

1. Move surface_id.mojom to cc/ipc, this matches gpu/ipc/common's placement for mojoms.

2. Write a StructTraits class for cc::SurfaceId.

3. Update usage.

BUG=611802
TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d60bd68eb0201e4ac7b6d196f66c3bff7592715e
Cr-Commit-Position: refs/heads/master@{#396387}

[Fady Samuel, 2016-05-26 16:38:41]

Description was changed from

==========
Implement cc::SurfaceId StructTraits

BUG=611802
==========

to

==========
Implement cc::SurfaceId StructTraits

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-05-26 16:40:11]

Description was changed from

==========
Implement cc::SurfaceId StructTraits

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement cc::SurfaceId StructTraits

1. Move surface_id.mojom to cc/ipc, this matches gpu/ipc/common's placement for
mojoms.

2. Write a StructTraits class for cc::SurfaceId.

3. Update usage.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-05-26 16:40:44]

fsamuel@chromium.org changed reviewers:
+ rockot@chromium.org

[Fady Samuel, 2016-05-26 16:40:44]

Just getting my feet wet.

[Ken Rockot(use gerrit already), 2016-05-26 16:58:22]

Looks great to me. Just some comments about build targets.

https://codereview.chromium.org/2014233002/diff/1/cc/ipc/cc_struct_traits.h
File cc/ipc/cc_struct_traits.h (right):

https://codereview.chromium.org/2014233002/diff/1/cc/ipc/cc_struct_traits.h#n...
cc/ipc/cc_struct_traits.h:1: // Copyright 2016 The Chromium Authors. All rights
reserved.
This file needs to be included in some target's sources so dependencies can be
expressed properly. Using a component target does not make sense, so
//cc/ipc:ipc itself won't work. How about introducing (in //cc/ipc/BUILD.gn):

source_set("mojom_struct_traits") {
  sources = [
    "cc_struct_traits.h"
  ]

  public_deps = [
    # ...  whatever (anything the header depends on is a public dep)
  ]
}

https://codereview.chromium.org/2014233002/diff/1/cc/ipc/surface_id.typemap
File cc/ipc/surface_id.typemap (right):

https://codereview.chromium.org/2014233002/diff/1/cc/ipc/surface_id.typemap#n...
cc/ipc/surface_id.typemap:8: deps = [ "//cc/surfaces", ]
This will also need a deps on the suggested "//cc/ipc:mojom_struct_traits"
target

https://codereview.chromium.org/2014233002/diff/1/components/mus/public/inter...
File components/mus/public/interfaces/BUILD.gn (right):

https://codereview.chromium.org/2014233002/diff/1/components/mus/public/inter...
components/mus/public/interfaces/BUILD.gn:39: deps = [
Please update this to public_deps while you're here. mojom deps are deprecated
(and equivalent to public_deps), but I'd prefer rules be explicit about the
meaning.

https://codereview.chromium.org/2014233002/diff/1/components/mus/ws/BUILD.gn
File components/mus/ws/BUILD.gn (right):

https://codereview.chromium.org/2014233002/diff/1/components/mus/ws/BUILD.gn#...
components/mus/ws/BUILD.gn:95: "//cc/ipc:interfaces",
Please fix these dependencies while you're here.

To wit, at least //cc/ipc:interfaces and //components/mus/public/interfaces
should be in public_deps rather than deps, because they're exposed by this
target's headers.

There are probably several other targets in deps here that should be in
public_deps as well. Sadly there are similar mistakes alllll over src/, but it's
particularly troublesome when generated files are involved as it can easily lead
to latent build flake.

As a general rule, if it's exposed by a header that your dependents might
include (e.g. mus/mus_app.cc includes window_tree.h), it MUST be in public_deps.

https://codereview.chromium.org/2014233002/diff/1/mojo/converters/surfaces/BU...
File mojo/converters/surfaces/BUILD.gn (right):

https://codereview.chromium.org/2014233002/diff/1/mojo/converters/surfaces/BU...
mojo/converters/surfaces/BUILD.gn:26: deps = [
Same note about public_deps here.

https://codereview.chromium.org/2014233002/diff/1/mojo/converters/surfaces/su...
File mojo/converters/surfaces/surfaces_type_converters.h (left):

https://codereview.chromium.org/2014233002/diff/1/mojo/converters/surfaces/su...
mojo/converters/surfaces/surfaces_type_converters.h:37: struct
MOJO_SURFACES_EXPORT
Woohoo!

[Fady Samuel, 2016-05-26 17:45:09]

PTAL Ken. I'll pass this along to sky@ and danakj@ once you're happy with this.

https://codereview.chromium.org/2014233002/diff/1/cc/ipc/cc_struct_traits.h
File cc/ipc/cc_struct_traits.h (right):

https://codereview.chromium.org/2014233002/diff/1/cc/ipc/cc_struct_traits.h#n...
cc/ipc/cc_struct_traits.h:1: // Copyright 2016 The Chromium Authors. All rights
reserved.
On 2016/05/26 16:58:21, Ken Rockot wrote:
> This file needs to be included in some target's sources so dependencies can be
> expressed properly. Using a component target does not make sense, so
> //cc/ipc:ipc itself won't work. How about introducing (in //cc/ipc/BUILD.gn):
> 
> source_set("mojom_struct_traits") {
>   sources = [
>     "cc_struct_traits.h"
>   ]
> 
>   public_deps = [
>     # ...  whatever (anything the header depends on is a public dep)
>   ]
> }

This creates a circular dependency. As per offline conversation I'm ignoring
this request.

https://codereview.chromium.org/2014233002/diff/1/cc/ipc/surface_id.typemap
File cc/ipc/surface_id.typemap (right):

https://codereview.chromium.org/2014233002/diff/1/cc/ipc/surface_id.typemap#n...
cc/ipc/surface_id.typemap:8: deps = [ "//cc/surfaces", ]
On 2016/05/26 16:58:21, Ken Rockot wrote:
> This will also need a deps on the suggested "//cc/ipc:mojom_struct_traits"
> target

I suppose it just needs mojom_struct_traits since that has cc/surfaces as
public_deps.

https://codereview.chromium.org/2014233002/diff/1/components/mus/public/inter...
File components/mus/public/interfaces/BUILD.gn (right):

https://codereview.chromium.org/2014233002/diff/1/components/mus/public/inter...
components/mus/public/interfaces/BUILD.gn:39: deps = [
On 2016/05/26 16:58:21, Ken Rockot wrote:
> Please update this to public_deps while you're here. mojom deps are deprecated
> (and equivalent to public_deps), but I'd prefer rules be explicit about the
> meaning.

Done.

https://codereview.chromium.org/2014233002/diff/1/components/mus/ws/BUILD.gn
File components/mus/ws/BUILD.gn (right):

https://codereview.chromium.org/2014233002/diff/1/components/mus/ws/BUILD.gn#...
components/mus/ws/BUILD.gn:95: "//cc/ipc:interfaces",
On 2016/05/26 16:58:22, Ken Rockot wrote:
> Please fix these dependencies while you're here.
> 
> To wit, at least //cc/ipc:interfaces and //components/mus/public/interfaces
> should be in public_deps rather than deps, because they're exposed by this
> target's headers.
> 
> There are probably several other targets in deps here that should be in
> public_deps as well. Sadly there are similar mistakes alllll over src/, but
it's
> particularly troublesome when generated files are involved as it can easily
lead
> to latent build flake.
> 
> As a general rule, if it's exposed by a header that your dependents might
> include (e.g. mus/mus_app.cc includes window_tree.h), it MUST be in
public_deps.

I've moved the interfaces over. I haven't done an exhaustive move of things that
should move to public_deps.

https://codereview.chromium.org/2014233002/diff/1/mojo/converters/surfaces/BU...
File mojo/converters/surfaces/BUILD.gn (right):

https://codereview.chromium.org/2014233002/diff/1/mojo/converters/surfaces/BU...
mojo/converters/surfaces/BUILD.gn:26: deps = [
On 2016/05/26 16:58:22, Ken Rockot wrote:
> Same note about public_deps here.

Done.

https://codereview.chromium.org/2014233002/diff/1/mojo/converters/surfaces/su...
File mojo/converters/surfaces/surfaces_type_converters.h (left):

https://codereview.chromium.org/2014233002/diff/1/mojo/converters/surfaces/su...
mojo/converters/surfaces/surfaces_type_converters.h:37: struct
MOJO_SURFACES_EXPORT
On 2016/05/26 16:58:22, Ken Rockot wrote:
> Woohoo!

Acknowledged.

[Ken Rockot(use gerrit already), 2016-05-26 17:55:10]

lgtm

https://codereview.chromium.org/2014233002/diff/1/components/mus/ws/BUILD.gn
File components/mus/ws/BUILD.gn (right):

https://codereview.chromium.org/2014233002/diff/1/components/mus/ws/BUILD.gn#...
components/mus/ws/BUILD.gn:95: "//cc/ipc:interfaces",
On 2016/05/26 at 17:45:09, Fady Samuel wrote:
> On 2016/05/26 16:58:22, Ken Rockot wrote:
> > Please fix these dependencies while you're here.
> > 
> > To wit, at least //cc/ipc:interfaces and //components/mus/public/interfaces
> > should be in public_deps rather than deps, because they're exposed by this
> > target's headers.
> > 
> > There are probably several other targets in deps here that should be in
> > public_deps as well. Sadly there are similar mistakes alllll over src/, but
it's
> > particularly troublesome when generated files are involved as it can easily
lead
> > to latent build flake.
> > 
> > As a general rule, if it's exposed by a header that your dependents might
> > include (e.g. mus/mus_app.cc includes window_tree.h), it MUST be in
public_deps.
> 
> I've moved the interfaces over. I haven't done an exhaustive move of things
that should move to public_deps.

I'd kind of prefer that you did. It doesn't seem like much more effort to just
correct these things now.

[Fady Samuel, 2016-05-26 19:54:28]

fsamuel@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[Fady Samuel, 2016-05-26 19:54:29]

+sky@ for mus
+tsepez@ for ipc.

https://codereview.chromium.org/2014233002/diff/1/components/mus/ws/BUILD.gn
File components/mus/ws/BUILD.gn (right):

https://codereview.chromium.org/2014233002/diff/1/components/mus/ws/BUILD.gn#...
components/mus/ws/BUILD.gn:95: "//cc/ipc:interfaces",
On 2016/05/26 17:55:10, Ken Rockot wrote:
> On 2016/05/26 at 17:45:09, Fady Samuel wrote:
> > On 2016/05/26 16:58:22, Ken Rockot wrote:
> > > Please fix these dependencies while you're here.
> > > 
> > > To wit, at least //cc/ipc:interfaces and
//components/mus/public/interfaces
> > > should be in public_deps rather than deps, because they're exposed by this
> > > target's headers.
> > > 
> > > There are probably several other targets in deps here that should be in
> > > public_deps as well. Sadly there are similar mistakes alllll over src/,
but
> it's
> > > particularly troublesome when generated files are involved as it can
easily
> lead
> > > to latent build flake.
> > > 
> > > As a general rule, if it's exposed by a header that your dependents might
> > > include (e.g. mus/mus_app.cc includes window_tree.h), it MUST be in
> public_deps.
> > 
> > I've moved the interfaces over. I haven't done an exhaustive move of things
> that should move to public_deps.
> 
> I'd kind of prefer that you did. It doesn't seem like much more effort to just
> correct these things now.

Seems like everything should be a public dep here. Done.

[Tom Sepez, 2016-05-26 20:02:45]

lgtm

[Fady Samuel, 2016-05-26 20:23:26]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-26 20:24:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014233002/40001

[commit-bot: I haz the power, 2016-05-26 20:27:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 20:27:06]

Dry run: Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Fady Samuel, 2016-05-26 20:50:06]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-26 20:50:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014233002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014233002/60001

[commit-bot: I haz the power, 2016-05-26 20:56:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 20:56:24]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Fady Samuel, 2016-05-26 20:58:40]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-26 20:59:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014233002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014233002/80001

[sky, 2016-05-26 20:59:41]

LGTM

[commit-bot: I haz the power, 2016-05-26 21:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 21:18:43]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Fady Samuel, 2016-05-26 23:21:31]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-05-26 23:21:31]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
tsepez@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2014233002/#ps100001
(title: "Fixed unittests")

[commit-bot: I haz the power, 2016-05-26 23:22:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014233002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014233002/100001

[commit-bot: I haz the power, 2016-05-26 23:30:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 23:30:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-05-26 23:32:24]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org

[Fady Samuel, 2016-05-26 23:32:25]

+danakj, looks like I need a cc OWNER too.

[danakj, 2016-05-26 23:58:02]

https://codereview.chromium.org/2014233002/diff/100001/cc/ipc/surface_id.typemap
File cc/ipc/surface_id.typemap (right):

https://codereview.chromium.org/2014233002/diff/100001/cc/ipc/surface_id.type...
cc/ipc/surface_id.typemap:7: traits_headers = [ "//cc/ipc/cc_struct_traits.h" ]
why the double cc?

is this header going to be for allll struct traits? why not
cc/ipc/surface_id_struct_traits.h or something?

[Fady Samuel, 2016-05-27 00:53:21]

TBR'ing Dana because she's out until 5/31. Thanks! Dana please let me know if
you'd like further changes when you get back! Thanks!

https://codereview.chromium.org/2014233002/diff/100001/cc/ipc/surface_id.typemap
File cc/ipc/surface_id.typemap (right):

https://codereview.chromium.org/2014233002/diff/100001/cc/ipc/surface_id.type...
cc/ipc/surface_id.typemap:7: traits_headers = [ "//cc/ipc/cc_struct_traits.h" ]
On 2016/05/26 23:58:02, danakj_OOO_back_5.31 wrote:
> why the double cc?
> 
> is this header going to be for allll struct traits? why not
> cc/ipc/surface_id_struct_traits.h or something?

Done.

[Fady Samuel, 2016-05-27 00:53:37]

Description was changed from

==========
Implement cc::SurfaceId StructTraits

1. Move surface_id.mojom to cc/ipc, this matches gpu/ipc/common's placement for
mojoms.

2. Write a StructTraits class for cc::SurfaceId.

3. Update usage.

BUG=611802
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement cc::SurfaceId StructTraits

1. Move surface_id.mojom to cc/ipc, this matches gpu/ipc/common's placement for
mojoms.

2. Write a StructTraits class for cc::SurfaceId.

3. Update usage.

BUG=611802
TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Fady Samuel, 2016-05-27 00:53:46]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-05-27 00:53:46]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2014233002/#ps120001
(title: "Addressed Dana's comment")

[commit-bot: I haz the power, 2016-05-27 00:54:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014233002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014233002/120001

[danakj, 2016-05-27 01:17:55]

LGTM

[commit-bot: I haz the power, 2016-05-27 02:47:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 02:47:47]

Failed to apply patch for components/mus/public/interfaces/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: components/mus/public/interfaces/BUILD.gn:37
  Falling back to three-way merge...
  Applied patch to 'components/mus/public/interfaces/BUILD.gn' with conflicts.
  U components/mus/public/interfaces/BUILD.gn

Patch:       components/mus/public/interfaces/BUILD.gn
Index: components/mus/public/interfaces/BUILD.gn
diff --git a/components/mus/public/interfaces/BUILD.gn
b/components/mus/public/interfaces/BUILD.gn
index
556ea864f6a5e36224bdfa23e06146310c54984b..c5b87a49965c56f59b98bfdae2ff715cf24aa5a0
100644
--- a/components/mus/public/interfaces/BUILD.gn
+++ b/components/mus/public/interfaces/BUILD.gn
@@ -22,7 +22,6 @@ mojom("interfaces") {
     "input_key_codes.mojom",
     "mus_constants.mojom",
     "quads.mojom",
-    "surface_id.mojom",
     "user_access_manager.mojom",
     "window_manager.mojom",
     "window_manager_constants.mojom",
@@ -37,7 +36,8 @@ mojom("interfaces") {
     "//mojo/services",
   ]
 
-  deps = [
+  public_deps = [
+    "//cc/ipc:interfaces",
     "//gpu/ipc/common:interfaces",
     "//ui/gfx/geometry/mojo:interfaces",
     "//ui/mojo/ime:interfaces",

[Fady Samuel, 2016-05-27 03:19:06]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-05-27 03:19:06]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org, sky@chromium.org, danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2014233002/#ps140001
(title: "Rebased")

[commit-bot: I haz the power, 2016-05-27 03:19:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014233002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014233002/140001

[commit-bot: I haz the power, 2016-05-27 04:38:54]

Description was changed from

==========
Implement cc::SurfaceId StructTraits

1. Move surface_id.mojom to cc/ipc, this matches gpu/ipc/common's placement for
mojoms.

2. Write a StructTraits class for cc::SurfaceId.

3. Update usage.

BUG=611802
TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement cc::SurfaceId StructTraits

1. Move surface_id.mojom to cc/ipc, this matches gpu/ipc/common's placement for
mojoms.

2. Write a StructTraits class for cc::SurfaceId.

3. Update usage.

BUG=611802
TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-27 04:38:56]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-05-27 04:41:54]

Description was changed from

==========
Implement cc::SurfaceId StructTraits

1. Move surface_id.mojom to cc/ipc, this matches gpu/ipc/common's placement for
mojoms.

2. Write a StructTraits class for cc::SurfaceId.

3. Update usage.

BUG=611802
TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Implement cc::SurfaceId StructTraits

1. Move surface_id.mojom to cc/ipc, this matches gpu/ipc/common's placement for
mojoms.

2. Write a StructTraits class for cc::SurfaceId.

3. Update usage.

BUG=611802
TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/d60bd68eb0201e4ac7b6d196f66c3bff7592715e
Cr-Commit-Position: refs/heads/master@{#396387}
==========

[commit-bot: I haz the power, 2016-05-27 04:41:55]

Patchset 8 (id:??) landed as
https://crrev.com/d60bd68eb0201e4ac7b6d196f66c3bff7592715e
Cr-Commit-Position: refs/heads/master@{#396387}

[dcheng, 2016-05-28 22:21:58]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-05-28 22:21:59]

Can you update //cc/ipc/OWNERS to cover the mojom files too? Thanks.

[Fady Samuel, 2016-06-02 02:27:49]

On 2016/05/28 22:21:59, dcheng wrote:
> Can you update //cc/ipc/OWNERS to cover the mojom files too? Thanks.

In CQ: https://codereview.chromium.org/2032723002/