Implement cc::SurfaceId StructTraits

components/mus/ws/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/ui.gni")
 import("//testing/test.gni")
 import("//mojo/public/mojo_application.gni")
 import("//mojo/public/mojo_application_manifest.gni")
 
 source_set("lib") {
@@ skipping 74 matching lines @@
     "window_tree_binding.h",
     "window_tree_factory.cc",
     "window_tree_factory.h",
     "window_tree_host_factory.cc",
     "window_tree_host_factory.h",
   ]
 
   deps = [
     "//base",
     "//cc",
+    "//cc/ipc:interfaces",

[Ken Rockot(use gerrit already), 2016/05/26 16:58:22]

Please fix these dependencies while you're here.

To wit, at least //cc/ipc:interfaces and //components/mus/public/interfaces
should be in public_deps rather than deps, because they're exposed by this
target's headers.

There are probably several other targets in deps here that should be in
public_deps as well. Sadly there are similar mistakes alllll over src/, but it's
particularly troublesome when generated files are involved as it can easily lead
to latent build flake.

As a general rule, if it's exposed by a header that your dependents might
include (e.g. mus/mus_app.cc includes window_tree.h), it MUST be in public_deps.

[Fady Samuel, 2016/05/26 17:45:09]

I've moved the interfaces over. I haven't done an exhaustive move of things that
should move to public_deps.

[Ken Rockot(use gerrit already), 2016/05/26 17:55:10]

I'd kind of prefer that you did. It doesn't seem like much more effort to just
correct these things now.

[Fady Samuel, 2016/05/26 19:54:29]

Seems like everything should be a public dep here. Done.

     "//cc/surfaces",
     "//cc/surfaces:surface_id",
     "//components/mus/common:mus_common",
     "//components/mus/gles2",
     "//components/mus/public/interfaces",
     "//components/mus/surfaces",
     "//mojo/common:common_base",
     "//mojo/converters/geometry",
     "//mojo/converters/ime",
     "//mojo/converters/input_events",
@@ skipping 131 matching lines @@
 
   data_deps = [
     ":mus_ws_unittests_app_manifest",
   ]
 }
 
 mojo_application_manifest("mus_ws_unittests_app_manifest") {
   application_name = "mus_ws_unittests_app"
   source = "mus_ws_unittests_app_manifest.json"
 }