Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/common/custom_handlers/protocol_handler.h

Issue 2014103002: Remove deprecated ListValue::Append(Value*) overload on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ADL fail Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/custom_handlers/protocol_handler.h
diff --git a/chrome/common/custom_handlers/protocol_handler.h b/chrome/common/custom_handlers/protocol_handler.h
index 745a3f52d5a67caaff9d1b19b11f83cc9b45f7c1..69c195c7c5628e6380a88849f2ea27bfe038954f 100644
--- a/chrome/common/custom_handlers/protocol_handler.h
+++ b/chrome/common/custom_handlers/protocol_handler.h
@@ -5,6 +5,7 @@
#ifndef CHROME_COMMON_CUSTOM_HANDLERS_PROTOCOL_HANDLER_H_
#define CHROME_COMMON_CUSTOM_HANDLERS_PROTOCOL_HANDLER_H_
+#include <memory>
#include <string>
#include "base/values.h"
@@ -41,9 +42,8 @@ class ProtocolHandler {
// ignored.
bool IsEquivalent(const ProtocolHandler& other) const;
- // Encodes this protocol handler as a DictionaryValue. The caller is
- // responsible for deleting the returned value.
- base::DictionaryValue* Encode() const;
+ // Encodes this protocol handler as a DictionaryValue.
+ std::unique_ptr<base::DictionaryValue> Encode() const;
const std::string& protocol() const { return protocol_; }
const GURL& url() const { return url_;}
« no previous file with comments | « chrome/browser/sync/test/integration/preferences_helper.cc ('k') | chrome/common/custom_handlers/protocol_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698