Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/common/custom_handlers/protocol_handler.cc

Issue 2014103002: Remove deprecated ListValue::Append(Value*) overload on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ADL fail Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/custom_handlers/protocol_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/custom_handlers/protocol_handler.cc
diff --git a/chrome/common/custom_handlers/protocol_handler.cc b/chrome/common/custom_handlers/protocol_handler.cc
index 75fc2744310eb19e86b97f580b724ff5ca2dc328..63f3d9ac3de007132c732daad82ff17c545c328b 100644
--- a/chrome/common/custom_handlers/protocol_handler.cc
+++ b/chrome/common/custom_handlers/protocol_handler.cc
@@ -4,6 +4,7 @@
#include "chrome/common/custom_handlers/protocol_handler.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "net/base/escape.h"
@@ -58,8 +59,8 @@ GURL ProtocolHandler::TranslateUrl(const GURL& url) const {
return GURL(translatedUrlSpec);
}
-base::DictionaryValue* ProtocolHandler::Encode() const {
- base::DictionaryValue* d = new base::DictionaryValue();
+std::unique_ptr<base::DictionaryValue> ProtocolHandler::Encode() const {
+ auto d = base::MakeUnique<base::DictionaryValue>();
d->Set("protocol", new base::StringValue(protocol_));
d->Set("url", new base::StringValue(url_.spec()));
return d;
« no previous file with comments | « chrome/common/custom_handlers/protocol_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698