Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2014093002: Fix LayoutObject::paintingLayer() about multicol spanner (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix LayoutObject::paintingLayer() about multicol spanner This fixes LayoutObject::paintLayer() for the following case: <div style="columns: 3"> <div style="column-span: all"> <div style="overflow: hidden"></div> </div> </div> The inner div has a non-self-painting layer whose parent layer is the multicol flow thread layer because layout tree and layer tree structure follows the dom structure. However, the multicol flow thread layer is not the actual painting layer but the column container layer is. When looking for the painting layer, we need to follow the layout tree instead of the layer tree and skip to the multicol container when we see a spanner. BUG=611609 TEST=LayoutObjectTest.PaintingLayerOfOverflowClipLayerUnderColumnSpanAll Committed: https://crrev.com/db39a0e1882876a8c833821caf0544e8155eaa72 Cr-Commit-Position: refs/heads/master@{#396259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Xianzhu
4 years, 7 months ago (2016-05-25 23:25:36 UTC) #2
Xianzhu
mstensho@opera.com is on vacation.
4 years, 7 months ago (2016-05-26 17:43:16 UTC) #4
mstensho (USE GERRIT)
lgtm (I haven't actually left yet. Tomorrow is my last day before August) A slightly ...
4 years, 7 months ago (2016-05-26 17:57:32 UTC) #6
Xianzhu
On 2016/05/26 17:57:32, mstensho (back 2016-08-08) wrote: > lgtm > > (I haven't actually left ...
4 years, 7 months ago (2016-05-26 18:09:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014093002/1
4 years, 7 months ago (2016-05-26 18:10:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 19:45:51 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 19:47:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db39a0e1882876a8c833821caf0544e8155eaa72
Cr-Commit-Position: refs/heads/master@{#396259}

Powered by Google App Engine
This is Rietveld 408576698