Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2014093002: Fix LayoutObject::paintingLayer() about multicol spanner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
621 return toLayoutBoxModelObject(current)->layer(); 621 return toLayoutBoxModelObject(current)->layer();
622 } 622 }
623 // FIXME: we should get rid of detached layout subtrees, at which point this code should 623 // FIXME: we should get rid of detached layout subtrees, at which point this code should
624 // not be reached. crbug.com/411429 624 // not be reached. crbug.com/411429
625 return nullptr; 625 return nullptr;
626 } 626 }
627 627
628 PaintLayer* LayoutObject::paintingLayer() const 628 PaintLayer* LayoutObject::paintingLayer() const
629 { 629 {
630 for (const LayoutObject* current = this; current; current = current->isColum nSpanAll() ? current->containingBlock() : current->parent()) { 630 for (const LayoutObject* current = this; current; current = current->isColum nSpanAll() ? current->containingBlock() : current->parent()) {
631 if (current->hasLayer()) 631 if (current->hasLayer() && toLayoutBoxModelObject(current)->layer()->isS elfPaintingLayer())
632 return toLayoutBoxModelObject(current)->layer()->enclosingSelfPainti ngLayer(); 632 return toLayoutBoxModelObject(current)->layer();
633 } 633 }
634 return nullptr; 634 return nullptr;
635 } 635 }
636 636
637 bool LayoutObject::scrollRectToVisible(const LayoutRect& rect, const ScrollAlign ment& alignX, const ScrollAlignment& alignY, ScrollType scrollType, bool makeVis ibleInVisualViewport) 637 bool LayoutObject::scrollRectToVisible(const LayoutRect& rect, const ScrollAlign ment& alignX, const ScrollAlignment& alignY, ScrollType scrollType, bool makeVis ibleInVisualViewport)
638 { 638 {
639 LayoutBox* enclosingBox = this->enclosingBox(); 639 LayoutBox* enclosingBox = this->enclosingBox();
640 if (!enclosingBox) 640 if (!enclosingBox)
641 return false; 641 return false;
642 642
(...skipping 3058 matching lines...) Expand 10 before | Expand all | Expand 10 after
3701 const blink::LayoutObject* root = object1; 3701 const blink::LayoutObject* root = object1;
3702 while (root->parent()) 3702 while (root->parent())
3703 root = root->parent(); 3703 root = root->parent();
3704 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3704 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3705 } else { 3705 } else {
3706 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n"); 3706 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n");
3707 } 3707 }
3708 } 3708 }
3709 3709
3710 #endif 3710 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698