Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2014073002: [DevTools] Focus DevTools when revealing setting. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Focus DevTools when revealing setting. BUG=612723 Committed: https://crrev.com/ff12f01dbdda4dab6ec240ca393d5cb5d77c133d Cr-Commit-Position: refs/heads/master@{#396102}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 3 chunks +3 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
dgozman
Take a look please.
4 years, 7 months ago (2016-05-25 22:47:24 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2014073002/diff/1/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js File third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js (right): https://codereview.chromium.org/2014073002/diff/1/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js#newcode587 third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js:587: InspectorFrontendHost.bringToFront(); why not inline this in showSettingsScreen method? ...
4 years, 7 months ago (2016-05-26 00:11:46 UTC) #3
dgozman
https://codereview.chromium.org/2014073002/diff/1/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js File third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js (right): https://codereview.chromium.org/2014073002/diff/1/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js#newcode587 third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js:587: InspectorFrontendHost.bringToFront(); On 2016/05/26 00:11:46, lushnikov wrote: > why not ...
4 years, 7 months ago (2016-05-26 00:18:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014073002/1
4 years, 7 months ago (2016-05-26 00:18:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 03:34:42 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 03:37:34 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ff12f01dbdda4dab6ec240ca393d5cb5d77c133d
Cr-Commit-Position: refs/heads/master@{#396102}

Powered by Google App Engine
This is Rietveld 408576698