Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

Issue 2014073002: [DevTools] Focus DevTools when revealing setting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
diff --git a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
index 42ea06e74e6b55ef2d307d2c014ca077067ab23e..38aa0d413805e3d42a42f52e6a767bf00607bd44 100644
--- a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
+++ b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
@@ -558,6 +558,7 @@ WebInspector.SettingsController.Revealer.prototype = {
if (!WebInspector.GenericSettingsTab.isSettingVisible(extension))
return;
if (extension.descriptor()["settingName"] === setting.name) {
+ InspectorFrontendHost.bringToFront();
WebInspector._settingsController.showSettingsScreen("preferences");
success = true;
}
@@ -570,6 +571,7 @@ WebInspector.SettingsController.Revealer.prototype = {
{
var settings = extension.descriptor()["settings"];
if (settings && settings.indexOf(setting.name) !== -1) {
+ InspectorFrontendHost.bringToFront();
WebInspector._settingsController.showSettingsScreen("preferences");
success = true;
}
@@ -582,6 +584,7 @@ WebInspector.SettingsController.Revealer.prototype = {
{
var settings = extension.descriptor()["settings"];
if (settings && settings.indexOf(setting.name) !== -1) {
+ InspectorFrontendHost.bringToFront();
lushnikov 2016/05/26 00:11:46 why not inline this in showSettingsScreen method?
dgozman 2016/05/26 00:18:10 Not sure. May have unpredictable consequences.
WebInspector._settingsController.showSettingsScreen(extension.descriptor()["name"]);
success = true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698