third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py

index 90db4dcd41c62c6e9a728dd866adc5619b5f994a..37b0ea84ecc3efb84fb761b96a1d785db7bc13a3 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py

@@ -41,6 +41,7 @@ from webkitpy.layout_tests.port import test

class FactoryTest(unittest.TestCase):

"""Test that the factory creates the proper port object for given combination of port_name, host.platform, and options."""

# FIXME: The ports themselves should expose what options they require,

# instead of passing generic "options".