third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

index 3617dc74a87e00b7d0a8dc48e36ca4147115d794..b9f95a8714f5cb1d7503914f1ad7756113e53e0e 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py

@@ -34,6 +34,7 @@ import re

from webkitpy.common.webkit_finder import WebKitFinder

def platform_options(use_globs=False):

return [

optparse.make_option('--android', action='store_const', dest='platform',

@@ -161,7 +162,7 @@ class PortFactory(object):

module_name, class_name = port_name.rsplit('.', 1)

module = __import__(module_name, globals(), locals(), [], -1)

port_class_name = module.get_port_class_name(class_name)

- if port_class_name != None:

+ if port_class_name is not None:

cls = module.__dict__[port_class_name]

port_name = cls.determine_full_port_name(self._host, options, class_name)

return cls(self._host, port_name, options=options, **kwargs)