Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py
index b082338187e0a38a6c9e5455fd31c13d3a490f71..f693bb454cf0c96ac4cdc9030f178498204d4574 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart.py
@@ -39,6 +39,7 @@ _log = logging.getLogger(__name__)
class DumpReaderMultipart(DumpReader):
+
"""Base class for Linux and Android breakpad dump reader."""
def __init__(self, host, build_dir):
@@ -92,7 +93,7 @@ class DumpReaderMultipart(DumpReader):
return None
def _check_breakpad_tools_available(self):
- if self._breakpad_tools_available != None:
+ if self._breakpad_tools_available is not None:
return self._breakpad_tools_available
REQUIRED_BREAKPAD_TOOLS = [
@@ -119,7 +120,8 @@ class DumpReaderMultipart(DumpReader):
return self._host.filesystem.join(self._build_dir, "minidump_stackwalk")
def _path_to_generate_breakpad_symbols(self):
- return self._webkit_finder.path_from_chromium_base("components", "crash", "content", "tools", "generate_breakpad_symbols.py")
+ return self._webkit_finder.path_from_chromium_base(
+ "components", "crash", "content", "tools", "generate_breakpad_symbols.py")
def _symbols_dir(self):
return self._host.filesystem.join(self._build_dir, 'content_shell.syms')
@@ -170,6 +172,7 @@ def _symbolize_keepalive(queue):
class DumpReaderLinux(DumpReaderMultipart):
+
"""Linux breakpad dump reader."""
def _binaries_to_symbolize(self):
@@ -180,6 +183,7 @@ class DumpReaderLinux(DumpReaderMultipart):
class DumpReaderAndroid(DumpReaderMultipart):
+
"""Android breakpad dump reader."""
def _binaries_to_symbolize(self):

Powered by Google App Engine
This is Rietveld 408576698