Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2014043002: Make TracingImpl take a Shell* and args, instead of an ApplicationImpl*. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make TracingImpl take a Shell* and args, instead of an ApplicationImpl*. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/8671c2ca635677cf25a9d49aa01d67e6cd3d761b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -20 lines) Patch
M examples/echo/echo_benchmark.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/trace_me/trace_me_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/common/tracing_impl.h View 2 chunks +8 lines, -3 lines 0 comments Download
M mojo/common/tracing_impl.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M services/dart/content_handler_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/dart/dart_tracing.h View 1 chunk +1 line, -1 line 0 comments Download
M services/dart/dart_tracing.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/gfx/compositor/compositor_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/java_handler/java_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/native_viewport/app_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/input_manager/input_manager_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/launcher/launcher_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/view_manager/view_manager_app.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-25 21:33:29 UTC) #1
viettrungluu
ping
4 years, 6 months ago (2016-05-26 17:56:41 UTC) #2
vardhan
lgtm
4 years, 6 months ago (2016-05-26 18:04:37 UTC) #3
viettrungluu
4 years, 6 months ago (2016-05-26 18:18:19 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8671c2ca635677cf25a9d49aa01d67e6cd3d761b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698