services/dart/content_handler_app.cc - Issue 2014043002: Make TracingImpl take a Shell* and args, instead of an ApplicationImpl*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/dart/content_handler_app.cc

Issue 2014043002: Make TracingImpl take a Shell* and args, instead of an ApplicationImpl*. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: services/dart/content_handler_app.cc

diff --git a/services/dart/content_handler_app.cc b/services/dart/content_handler_app.cc

index 5db8dac401656daa714e191a97b698aa944b5598..380cd9224e383425472e30e980f195b6c91fb7f0 100644

--- a/services/dart/content_handler_app.cc

+++ b/services/dart/content_handler_app.cc

@@ -132,9 +132,9 @@ bool DartContentHandlerApp::run_on_message_loop() const {

void DartContentHandlerApp::Initialize(mojo::ApplicationImpl* app) {

// Tracing of content handler and controller.

- tracing_.Initialize(app);

+ tracing_.Initialize(app->shell(), &app->args());

// Tracing of isolates and VM.

- dart_tracing_.Initialize(app);

+ dart_tracing_.Initialize(app->shell());

// TODO(qsr): This has no effect for now, as the tracing infrastructure

// doesn't allow to trace anything before the tracing app connects to the

« no previous file with comments | « mojo/common/tracing_impl.cc ('k') | services/dart/dart_tracing.h » ('j') | no next file with comments »