Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2014023003: Add exact version of qcms used by Chrome for testing and comparison (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add exact version of qcms used by Chrome for testing and comparison BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2014023003 Committed: https://skia.googlesource.com/skia/+/0e5b249e549a540bd89d525369b950c9e4404235

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8286 lines, -0 lines) Patch
M gyp/ports.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A gyp/qcms.gyp View 1 chunk +74 lines, -0 lines 0 comments Download
A third_party/qcms/BUILD.gn View 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/qcms/README.chromium View 1 chunk +162 lines, -0 lines 0 comments Download
A third_party/qcms/qcms.gyp View 1 chunk +113 lines, -0 lines 0 comments Download
A third_party/qcms/src/COPYING View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/qcms/src/README View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/qcms/src/chain.h View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/qcms/src/chain.c View 1 chunk +1026 lines, -0 lines 0 comments Download
A third_party/qcms/src/empty.c View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/qcms/src/halffloat.h View 1 chunk +106 lines, -0 lines 0 comments Download
A third_party/qcms/src/iccread.c View 1 chunk +1645 lines, -0 lines 0 comments Download
A third_party/qcms/src/matrix.h View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/qcms/src/matrix.c View 1 chunk +136 lines, -0 lines 0 comments Download
A third_party/qcms/src/qcms.h View 1 chunk +171 lines, -0 lines 0 comments Download
A third_party/qcms/src/qcms_util.c View 1 chunk +69 lines, -0 lines 0 comments Download
A third_party/qcms/src/qcmsint.h View 1 chunk +342 lines, -0 lines 0 comments Download
A third_party/qcms/src/qcmstypes.h View 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/qcms/src/tests/Makefile View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/qcms/src/tests/qcms_test_internal_srgb.c View 1 chunk +155 lines, -0 lines 0 comments Download
A third_party/qcms/src/tests/qcms_test_main.c View 1 chunk +131 lines, -0 lines 0 comments Download
A third_party/qcms/src/tests/qcms_test_munsell.c View 1 chunk +217 lines, -0 lines 0 comments Download
A third_party/qcms/src/tests/qcms_test_ntsc_gamut.c View 1 chunk +74 lines, -0 lines 0 comments Download
A third_party/qcms/src/tests/qcms_test_output_trc.c View 1 chunk +255 lines, -0 lines 0 comments Download
A third_party/qcms/src/tests/qcms_test_tetra_clut_rgba.c View 1 chunk +180 lines, -0 lines 0 comments Download
A third_party/qcms/src/tests/qcms_test_util.h View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/qcms/src/tests/qcms_test_util.c View 1 chunk +280 lines, -0 lines 0 comments Download
A third_party/qcms/src/tests/timing.h View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/qcms/src/transform.c View 1 chunk +1641 lines, -0 lines 0 comments Download
A third_party/qcms/src/transform-sse2.c View 1 chunk +458 lines, -0 lines 0 comments Download
A third_party/qcms/src/transform_util.h View 1 chunk +58 lines, -0 lines 0 comments Download
A third_party/qcms/src/transform_util.c View 1 chunk +639 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014023003/20001
4 years, 6 months ago (2016-05-26 17:13:20 UTC) #4
msarett
4 years, 6 months ago (2016-05-26 17:13:27 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-26 17:26:57 UTC) #8
commit-bot: I haz the power
Dry run: None
4 years, 6 months ago (2016-05-26 17:26:59 UTC) #9
reed1
lgtm perhaps append the comment to be : add exact-version-chrome-uses for ...
4 years, 6 months ago (2016-05-26 18:02:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014023003/20001
4 years, 6 months ago (2016-05-26 18:04:21 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 18:05:40 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/0e5b249e549a540bd89d525369b950c9e4404235

Powered by Google App Engine
This is Rietveld 408576698