Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2013983003: Fix WebView not to hide soft keyboard on navigation (Closed)

Created:
4 years, 6 months ago by Changwan Ryu
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fix WebView not to hide soft keyboard on navigation We were calling ImeAdapter#reset() (now renamed as resetAndHideKeyboard) whenever navigation occurred. This change was introduced in https://codereview.chromium.org/1278593004 . However, there are cases, e.g. email client using WebView, where we don't want the behavior. (b/27547367) We will still call resetAndHideKeyboard() when renderer process is gone as a safety net for ImeThread feature, and hide keyboard through updateKeyboardVisibility() function. BUG=601707 Review-Url: https://codereview.chromium.org/2001983002 Cr-Commit-Position: refs/heads/master@{#395535} (cherry picked from commit cbd74f1402d7f3d87b032ea9ee1d4d65f6fcde8c) Committed: https://chromium.googlesource.com/chromium/src/+/b51b4d1b8571092c7e6883e83f6a682521975388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 3 chunks +4 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Changwan Ryu
4 years, 6 months ago (2016-05-26 01:41:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b51b4d1b8571092c7e6883e83f6a682521975388.

Powered by Google App Engine
This is Rietveld 408576698