Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2001983002: Fix WebView not to hide soft keyboard on navigation (Closed)

Created:
4 years, 7 months ago by Changwan Ryu
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WebView not to hide soft keyboard on navigation We were calling ImeAdapter#reset() (now renamed as resetAndHideKeyboard) whenever navigation occurred. This change was introduced in https://codereview.chromium.org/1278593004 . However, there are cases, e.g. email client using WebView, where we don't want the behavior. (b/27547367) We will still call resetAndHideKeyboard() when renderer process is gone as a safety net for ImeThread feature, and hide keyboard through updateKeyboardVisibility() function. BUG=601707 Committed: https://crrev.com/cbd74f1402d7f3d87b032ea9ee1d4d65f6fcde8c Cr-Commit-Position: refs/heads/master@{#395535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 3 chunks +4 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Changwan Ryu
4 years, 7 months ago (2016-05-23 06:03:46 UTC) #2
Ted C
lgtm
4 years, 7 months ago (2016-05-23 18:35:00 UTC) #3
aelias_OOO_until_Jul13
lgtm
4 years, 7 months ago (2016-05-23 20:04:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001983002/1
4 years, 7 months ago (2016-05-24 04:59:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 06:56:49 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 06:57:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbd74f1402d7f3d87b032ea9ee1d4d65f6fcde8c
Cr-Commit-Position: refs/heads/master@{#395535}

Powered by Google App Engine
This is Rietveld 408576698