Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Side by Side Diff: ash/shelf/shelf_locking_manager.cc

Issue 2013933002: Fix shelf alignment locking for power button. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove compositor DCHECK workaround. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/accelerators/accelerator_table.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shelf/shelf_locking_manager.h" 5 #include "ash/shelf/shelf_locking_manager.h"
6 6
7 #include "ash/session/session_state_delegate.h" 7 #include "ash/session/session_state_delegate.h"
8 #include "ash/shelf/shelf.h" 8 #include "ash/shelf/shelf.h"
9 #include "ash/shell.h" 9 #include "ash/shell.h"
10 #include "ash/wm/lock_state_controller.h" 10 #include "ash/wm/lock_state_controller.h"
(...skipping 23 matching lines...) Expand all
34 UpdateLockedState(); 34 UpdateLockedState();
35 } 35 }
36 36
37 void ShelfLockingManager::SessionStateChanged( 37 void ShelfLockingManager::SessionStateChanged(
38 SessionStateDelegate::SessionState state) { 38 SessionStateDelegate::SessionState state) {
39 session_locked_ = state != SessionStateDelegate::SESSION_STATE_ACTIVE; 39 session_locked_ = state != SessionStateDelegate::SESSION_STATE_ACTIVE;
40 UpdateLockedState(); 40 UpdateLockedState();
41 } 41 }
42 42
43 void ShelfLockingManager::OnLockStateEvent(EventType event) { 43 void ShelfLockingManager::OnLockStateEvent(EventType event) {
44 // This is only called when locking the screen; there is no unlock event here. 44 // Lock when the animation starts, ignoring pre-lock. There's no unlock event.
45 // It's also called when the screen lock animation begins and should help the 45 screen_locked_ |= event == EVENT_LOCK_ANIMATION_STARTED;
46 // shelf appear locked much earlier than ShellObserver::OnLockStateChanged.
47 screen_locked_ = true;
48 UpdateLockedState(); 46 UpdateLockedState();
49 } 47 }
50 48
51 void ShelfLockingManager::UpdateLockedState() { 49 void ShelfLockingManager::UpdateLockedState() {
52 const wm::ShelfAlignment alignment = shelf_->alignment(); 50 const wm::ShelfAlignment alignment = shelf_->alignment();
53 if (is_locked() && alignment != wm::SHELF_ALIGNMENT_BOTTOM_LOCKED) { 51 if (is_locked() && alignment != wm::SHELF_ALIGNMENT_BOTTOM_LOCKED) {
54 stored_alignment_ = alignment; 52 stored_alignment_ = alignment;
55 shelf_->SetAlignment(wm::SHELF_ALIGNMENT_BOTTOM_LOCKED); 53 shelf_->SetAlignment(wm::SHELF_ALIGNMENT_BOTTOM_LOCKED);
56 } else if (!is_locked() && alignment == wm::SHELF_ALIGNMENT_BOTTOM_LOCKED) { 54 } else if (!is_locked() && alignment == wm::SHELF_ALIGNMENT_BOTTOM_LOCKED) {
57 shelf_->SetAlignment(stored_alignment_); 55 shelf_->SetAlignment(stored_alignment_);
58 } 56 }
59 } 57 }
60 58
61 } // namespace ash 59 } // namespace ash
OLDNEW
« no previous file with comments | « ash/accelerators/accelerator_table.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698