Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: crosstest/crosstest.cfg

Issue 2013863002: Subzero: Crosstest test_arith properly tests i8/i16. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Use a python script to auto-generate .ll tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Makefile.standalone ('k') | crosstest/test_arith.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crosstest/crosstest.cfg
diff --git a/crosstest/crosstest.cfg b/crosstest/crosstest.cfg
index a7d30b6de3d0786aaa5b05062fa50d0da5abde57..a9de168ddea762dd6959ae5fb05f6247a1a3777c 100644
--- a/crosstest/crosstest.cfg
+++ b/crosstest/crosstest.cfg
@@ -9,7 +9,14 @@ flags: --sz=-fmem-intrin-opt
[test_arith]
driver: test_arith_main.cpp
-test: test_arith.cpp test_arith_frem.ll test_arith_sqrt.ll test_arith_fabs.ll
+# Note: Originally test_arith.cpp was used to generate the bulk of the tests.
+# However, the C++ integral promotion rules mean that most of the time i8 and
+# i16 operations are not actually tested; instead, they are extended to i32 and
+# only the i32 operation is tested. To help fix this, the relevant parts of
+# test_arith.cpp are commented out, and instead a python script auto-generates
+# test_arith_ll.ll which contains the proper functionality.
+#test: test_arith.cpp test_arith_frem.ll test_arith_sqrt.ll test_arith_fabs.ll
+test: test_arith_ll.ll test_arith.cpp test_arith_sqrt.ll test_arith_fabs.ll
[test_bitmanip]
driver: test_bitmanip_main.cpp
« no previous file with comments | « Makefile.standalone ('k') | crosstest/test_arith.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698