Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: crosstest/test_arith.cpp

Issue 2013863002: Subzero: Crosstest test_arith properly tests i8/i16. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Use a python script to auto-generate .ll tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « crosstest/crosstest.cfg ('k') | crosstest/test_arith_ll.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crosstest/test_arith.cpp
diff --git a/crosstest/test_arith.cpp b/crosstest/test_arith.cpp
index 6ef2cc6878a6ec6ef1a19dd9c90486144120e2b6..f2658d85f45da033b5cdb750bed323eecf1bec17 100644
--- a/crosstest/test_arith.cpp
+++ b/crosstest/test_arith.cpp
@@ -19,6 +19,10 @@
#include "test_arith.h"
#include "xdefs.h"
+#if 0
+// The following is commented out, and instead, a python script auto-generates a
+// .ll file with the equivalent functionality.
+
#define X(inst, op, isdiv, isshift) \
bool test##inst(bool a, bool b) { return a op b; } \
uint8_t test##inst(uint8_t a, uint8_t b) { return a op b; } \
@@ -50,6 +54,8 @@ SINTOP_TABLE
FPOP_TABLE
#undef X
+#endif // 0
+
#define X(mult_by) \
bool testMultiplyBy##mult_by(bool a, bool /*unused*/) { \
return a * (mult_by); \
« no previous file with comments | « crosstest/crosstest.cfg ('k') | crosstest/test_arith_ll.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698