Subzero: Crosstest test_arith properly tests i8/i16.

Subzero: Crosstest test_arith properly tests i8/i16.

The problem is that because of C++ integral promotion rules, many of the i8 and i16 arithmetic tests were actually being performed as i32 operations.  Thus we weren't actually testing everything we meant to test.

The fix is to have a python script auto-generate the relevant tests with proper typing.

BUG= none
R=eholk@chromium.org, jpp@chromium.org, kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7dbe802225fc1ad5fa191a20ea8b0de7c5bafef6

[Jim Stichnoth, 2016-05-25 16:49:40]

Description was changed from

==========
Subzero: Crosstest test_arith properly tests i8/i16.

BUG= none
==========

to

==========
Subzero: Crosstest test_arith properly tests i8/i16.

The problem is that because of C++ integral promotion rules, many of the i8 and
i16 arithmetic tests were actually being performed as i32 operations.  Thus we
weren't actually testing everything we meant to test.

The fix is to capture pnacl-clang's output and manually tweak it (in 16 places)
to explicitly use the i8 or i16 operation.

BUG= none
==========

[Jim Stichnoth, 2016-05-25 16:49:41]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com

[Karl, 2016-05-25 16:52:10]

lgtm

[John, 2016-05-25 17:26:28]

lgtm

https://codereview.chromium.org/2013863002/diff/20001/crosstest/crosstest.cfg
File crosstest/crosstest.cfg (right):

https://codereview.chromium.org/2013863002/diff/20001/crosstest/crosstest.cfg...
crosstest/crosstest.cfg:15: # the i8/i16 form of the arithmetic instruction, to
counteract C++'s integral
It's not C++'s rule as the spec say types **can** be promoted. This seems more
like a pnacl-specific issue.

[Jim Stichnoth, 2016-05-27 18:22:20]

PTAL.

I adapted a python script from John to auto-generate the .ll file.  It's hooked
into the makefile similar to the script for auto-generating the ARM register
tables.

[Jim Stichnoth, 2016-05-27 18:23:16]

Description was changed from

==========
Subzero: Crosstest test_arith properly tests i8/i16.

The problem is that because of C++ integral promotion rules, many of the i8 and
i16 arithmetic tests were actually being performed as i32 operations.  Thus we
weren't actually testing everything we meant to test.

The fix is to capture pnacl-clang's output and manually tweak it (in 16 places)
to explicitly use the i8 or i16 operation.

BUG= none
==========

to

==========
Subzero: Crosstest test_arith properly tests i8/i16.

The problem is that because of C++ integral promotion rules, many of the i8 and
i16 arithmetic tests were actually being performed as i32 operations.  Thus we
weren't actually testing everything we meant to test.

The fix is to have a python script auto-generate the relevant tests with proper
typing.

BUG= none
==========

[Eric Holk, 2016-05-27 18:30:30]

lgtm

[Jim Stichnoth, 2016-05-31 19:21:54]

Description was changed from

==========
Subzero: Crosstest test_arith properly tests i8/i16.

The problem is that because of C++ integral promotion rules, many of the i8 and
i16 arithmetic tests were actually being performed as i32 operations.  Thus we
weren't actually testing everything we meant to test.

The fix is to have a python script auto-generate the relevant tests with proper
typing.

BUG= none
==========

to

==========
Subzero: Crosstest test_arith properly tests i8/i16.

The problem is that because of C++ integral promotion rules, many of the i8 and
i16 arithmetic tests were actually being performed as i32 operations.  Thus we
weren't actually testing everything we meant to test.

The fix is to have a python script auto-generate the relevant tests with proper
typing.

BUG= none
R=eholk@chromium.org, jpp@chromium.org, kschimpf@google.com

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-05-31 19:21:56]

Committed patchset #3 (id:40001) manually as
7dbe802225fc1ad5fa191a20ea8b0de7c5bafef6 (presubmit successful).