Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2013733002: Re-land: [mojo] Use a pipe path to initialise Mojo in elevated utility processes. (Closed)

Created:
4 years, 7 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: [mojo] Use a pipe path to initialise Mojo in elevated utility processes. Elevated processes can't be passed HANDLEs, so instead, IPC channels must be initialised by passing a pipe path on the command line. For security, passing a pipe path is only done for elevated process and no other process types. This reland is identical to the original: https://codereview.chromium.org/1893313003 The uninitialised read error that caused the revert is fixed separately at https://codereview.chromium.org/2008953003/ BUG=604282 TBR=rockot@chromium.org,forshaw@chromium.org,nick@chromium.org Committed: https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca Cr-Commit-Position: refs/heads/master@{#396766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -16 lines) Patch
M content/browser/child_process_launcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/child_process_launcher.cc View 4 chunks +18 lines, -6 lines 0 comments Download
M content/browser/utility_process_host_impl_browsertest.cc View 2 chunks +15 lines, -4 lines 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M mojo/edk/embedder/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A mojo/edk/embedder/named_platform_channel_pair.h View 1 chunk +64 lines, -0 lines 0 comments Download
A mojo/edk/embedder/named_platform_channel_pair_win.cc View 1 chunk +131 lines, -0 lines 0 comments Download
M mojo/edk/embedder/platform_handle.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/channel_win.cc View 5 chunks +38 lines, -0 lines 0 comments Download
M mojo/mojo_edk.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013733002/1
4 years, 6 months ago (2016-05-31 00:22:53 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-31 01:43:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013733002/1
4 years, 6 months ago (2016-05-31 01:50:36 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 01:54:25 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 01:56:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b613891eb01125a395923e5e7e73806757aa89ca
Cr-Commit-Position: refs/heads/master@{#396766}

Powered by Google App Engine
This is Rietveld 408576698