Issue 2013673002: ChannelMojo: Don't signal Channel errors with lock held

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2013673002: ChannelMojo: Don't signal Channel errors with lock held (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)

Modified:
4 years, 7 months ago

Reviewers:
Sam McNally

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

ChannelMojo: Don't signal Channel errors with lock held This eliminates a lock-order inversion between ChannelMojo and SyncMessageFilter. BUG=611338 R=sammc@chromium.org Review-Url: https://codereview.chromium.org/2000213002 Cr-Commit-Position: refs/heads/master@{#395483} (cherry picked from commit 06325bce94fafdd8df10ab1d41723a5a36587e0d) Committed: https://chromium.googlesource.com/chromium/src/+/9aae2383da1ee43b1e5980252cfde40a9ee7d41f

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
	M	ipc/mojo/ipc_channel_mojo.cc	View		1 chunk	+12 lines, -7 lines	0 comments	Download

Total messages: 2 (1 generated)

Ken Rockot(use gerrit already)

4 years, 7 months ago (2016-05-24 23:36:00 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9aae2383da1ee43b1e5980252cfde40a9ee7d41f.