Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2000213002: ChannelMojo: Don't signal Channel errors with lock held (Closed)

Created:
4 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 7 months ago
Reviewers:
Sam McNally
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChannelMojo: Don't signal Channel errors with lock held This eliminates a lock-order inversion between ChannelMojo and SyncMessageFilter. BUG=611338 R=sammc@chromium.org Committed: https://crrev.com/06325bce94fafdd8df10ab1d41723a5a36587e0d Cr-Commit-Position: refs/heads/master@{#395483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +12 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
4 years, 7 months ago (2016-05-23 15:58:33 UTC) #1
Sam McNally
lgtm
4 years, 7 months ago (2016-05-24 00:20:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2000213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2000213002/1
4 years, 7 months ago (2016-05-24 00:21:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 00:27:15 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 00:29:19 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/06325bce94fafdd8df10ab1d41723a5a36587e0d
Cr-Commit-Position: refs/heads/master@{#395483}

Powered by Google App Engine
This is Rietveld 408576698