[tracing] Fix V8 and PartitionAlloc dump provider for background mode

[tracing] Fix V8 and PartitionAlloc dump provider for background mode

For background mode, just dump same details as light mode.

BUG=613198
Committed: https://crrev.com/3011f204cda084e39ce76d93b62d885b57c8a2bf
Cr-Commit-Position: refs/heads/master@{#397228}

[ssid, 2016-05-31 22:53:59]

Description was changed from

==========
[tracing] Fix V8 and PartitionAlloc dump provider for background mode

For background mode, just do exacrtly same as light mode.

BUG=613198
==========

to

==========
[tracing] Fix V8 and PartitionAlloc dump provider for background mode

For background mode, just dump same details as light mode.

BUG=613198
==========

[ssid, 2016-05-31 23:01:51]

ssid@chromium.org changed reviewers:
+ haraken@chromium.org, jochen@chromium.org, primiano@chromium.org

[ssid, 2016-05-31 23:01:51]

+haraken for PartitionAlloc provider.

[ssid, 2016-05-31 23:02:24]

+jochen for gin/

[haraken, 2016-05-31 23:29:35]

LGTM

[Primiano Tucci (use gerrit), 2016-06-01 09:58:26]

LGTM

https://codereview.chromium.org/2013643005/diff/20001/gin/v8_isolate_memory_d...
File gin/v8_isolate_memory_dump_provider.cc (right):

https://codereview.chromium.org/2013643005/diff/20001/gin/v8_isolate_memory_d...
gin/v8_isolate_memory_dump_provider.cc:134: // Only if heavy dump is requested,
then object statistics are dumped.
The wording of this comment is a bit odd now.
Maybe:
// Dump object statistics only for detailed dumps.

[jochen (gone - plz use gerrit), 2016-06-01 15:17:30]

lgtm

[ssid, 2016-06-01 18:53:46]

Thanks.

https://codereview.chromium.org/2013643005/diff/20001/gin/v8_isolate_memory_d...
File gin/v8_isolate_memory_dump_provider.cc (right):

https://codereview.chromium.org/2013643005/diff/20001/gin/v8_isolate_memory_d...
gin/v8_isolate_memory_dump_provider.cc:134: // Only if heavy dump is requested,
then object statistics are dumped.
On 2016/06/01 09:58:26, Primiano Tucci wrote:
> The wording of this comment is a bit odd now.
> Maybe:
> // Dump object statistics only for detailed dumps.

Done.

[ssid, 2016-06-01 18:54:01]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-01 18:54:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013643005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013643005/40001

[commit-bot: I haz the power, 2016-06-01 20:08:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-01 20:08:54]

Dry run: This issue passed the CQ dry run.

[ssid, 2016-06-01 20:19:03]

The CQ bit was checked by ssid@chromium.org

[ssid, 2016-06-01 20:19:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, primiano@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2013643005/#ps40001
(title: "fix comment.")

[commit-bot: I haz the power, 2016-06-01 20:19:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013643005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013643005/40001

[commit-bot: I haz the power, 2016-06-01 20:24:40]

Description was changed from

==========
[tracing] Fix V8 and PartitionAlloc dump provider for background mode

For background mode, just dump same details as light mode.

BUG=613198
==========

to

==========
[tracing] Fix V8 and PartitionAlloc dump provider for background mode

For background mode, just dump same details as light mode.

BUG=613198
==========

[commit-bot: I haz the power, 2016-06-01 20:24:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-01 20:25:59]

Description was changed from

==========
[tracing] Fix V8 and PartitionAlloc dump provider for background mode

For background mode, just dump same details as light mode.

BUG=613198
==========

to

==========
[tracing] Fix V8 and PartitionAlloc dump provider for background mode

For background mode, just dump same details as light mode.

BUG=613198

Committed: https://crrev.com/3011f204cda084e39ce76d93b62d885b57c8a2bf
Cr-Commit-Position: refs/heads/master@{#397228}
==========

[commit-bot: I haz the power, 2016-06-01 20:26:00]

Patchset 3 (id:??) landed as
https://crrev.com/3011f204cda084e39ce76d93b62d885b57c8a2bf
Cr-Commit-Position: refs/heads/master@{#397228}