third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp - Issue 2013643005: [tracing] Fix V8 and PartitionAlloc dump provider for background mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

Issue 2013643005: [tracing] Fix V8 and PartitionAlloc dump provider for background mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@whitelist_mdp

Patch Set: fix comment. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

diff --git a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

index a931bb57660362c89d6608b2ed394219926bb832..1e2a7a5f4dd1a53df1b8ace89ded4446a2753255 100644

--- a/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

+++ b/third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp

@@ -136,7 +136,7 @@ bool PartitionAllocMemoryDumpProvider::OnMemoryDump(const base::trace_event::Mem

base::StringPrintf("%s/%s", kPartitionAllocDumpName, kPartitionsDumpName));

// This method calls memoryStats.partitionsDumpBucketStats with memory statistics.

- WTF::Partitions::dumpMemoryStats(levelOfDetail == MemoryDumpLevelOfDetail::LIGHT, &partitionStatsDumper);

+ WTF::Partitions::dumpMemoryStats(levelOfDetail != MemoryDumpLevelOfDetail::DETAILED, &partitionStatsDumper);

base::trace_event::MemoryAllocatorDump* allocatedObjectsDump = memoryDump->CreateAllocatorDump(Partitions::kAllocatedObjectPoolName);

allocatedObjectsDump->AddScalar("size", "bytes", partitionStatsDumper.totalActiveBytes());

« no previous file with comments | « gin/v8_isolate_memory_dump_provider.cc ('k') | no next file » | no next file with comments »