Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3732)

Unified Diff: chrome/browser/notifications/notification_ui_manager_impl.cc

Issue 20136004: Allow partial update for notification update API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add more tests per feedback Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_ui_manager_impl.cc
diff --git a/chrome/browser/notifications/notification_ui_manager_impl.cc b/chrome/browser/notifications/notification_ui_manager_impl.cc
index 6e15592f004e9a36938be8c9c0a3a76d3bdcf316..d2b08d02f53a8aca2464572b79766165d5c16d5a 100644
--- a/chrome/browser/notifications/notification_ui_manager_impl.cc
+++ b/chrome/browser/notifications/notification_ui_manager_impl.cc
@@ -74,13 +74,15 @@ void NotificationUIManagerImpl::Add(const Notification& notification,
CheckAndShowNotifications();
}
-bool NotificationUIManagerImpl::DoesIdExist(const std::string& id) {
- for (NotificationDeque::iterator iter = show_queue_.begin();
+const Notification* NotificationUIManagerImpl::FindById(
+ const std::string& id) const {
+ for (NotificationDeque::const_iterator iter = show_queue_.begin();
iter != show_queue_.end(); ++iter) {
- if ((*iter)->notification().notification_id() == id)
- return true;
+ if ((*iter)->notification().notification_id() == id) {
+ return &((*iter)->notification());
+ }
}
- return false;
+ return NULL;
}
bool NotificationUIManagerImpl::CancelById(const std::string& id) {

Powered by Google App Engine
This is Rietveld 408576698