chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc - Issue 20136004: Allow partial update for notification update API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc

Issue 20136004: Allow partial update for notification update API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add more tests per feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_ui_manager_impl.cc ('k') | chrome/browser/notifications/sync_notifier/synced_notification_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc

diff --git a/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc b/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc

index caedb246ab35caf4abaa5d16962ae64bad62d2da..2906a376a75776f65b5094e40d671687276592eb 100644

--- a/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc

+++ b/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc

@@ -65,8 +65,8 @@ class StubNotificationUIManager : public NotificationUIManager {

// Returns true if any notifications match the supplied ID, either currently

// displayed or in the queue.

- virtual bool DoesIdExist(const std::string& id) OVERRIDE {

- return true;

+ virtual const Notification* FindById(const std::string& id) const OVERRIDE {

+ return (notification_.id() == id) ? &notification_ : NULL;

}

// Removes any notifications matching the supplied ID, either currently