chrome/browser/notifications/balloon_collection.h - Issue 20136004: Allow partial update for notification update API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/balloon_collection.h

Issue 20136004: Allow partial update for notification update API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add more tests per feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/balloon_collection.h

diff --git a/chrome/browser/notifications/balloon_collection.h b/chrome/browser/notifications/balloon_collection.h

index cd17d1a18ebaa51d37c620ae4dca9ee4dfb00418..5d54b7d137d6334610781b5a1bed0402cbba3bc6 100644

--- a/chrome/browser/notifications/balloon_collection.h

+++ b/chrome/browser/notifications/balloon_collection.h

@@ -55,7 +55,7 @@ class BalloonCollection {

Profile* profile) = 0;

// Returns true if any balloon has this notification id.

- virtual bool DoesIdExist(const std::string& id) = 0;

+ virtual const Notification* FindById(const std::string& id) const = 0;

// Removes any balloons that have this notification id. Returns

// true if anything was removed.