chrome/browser/notifications/balloon_collection_base.h - Issue 20136004: Allow partial update for notification update API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/balloon_collection_base.h

Issue 20136004: Allow partial update for notification update API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add more tests per feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/balloon_collection_base.h

diff --git a/chrome/browser/notifications/balloon_collection_base.h b/chrome/browser/notifications/balloon_collection_base.h

index 8c4e442c31ce50e8ae85d4a51a93eeff9b48edcf..89f33414caf6de55aa7078b153d30d99f7946a83 100644

--- a/chrome/browser/notifications/balloon_collection_base.h

+++ b/chrome/browser/notifications/balloon_collection_base.h

@@ -34,7 +34,7 @@ class BalloonCollectionBase {

virtual void Remove(Balloon* balloon);

// Returns true if any balloon matches the given notification id.

- virtual bool DoesIdExist(const std::string& id);

+ virtual const Notification* FindById(const std::string& id) const;

// Finds any balloon matching the given notification id, and

// calls CloseByScript on it. Returns true if anything was