Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2013573003: Use EXPECT_FALSE instead of EXPECT_EQ(false to fix linux build with gcc (Closed)

Created:
4 years, 7 months ago by Julien Isorce Samsung
Modified:
4 years, 7 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, sadrul, zoltan1, grt+watch_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, kalyank, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use EXPECT_FALSE instead of EXPECT_EQ(false to fix linux build with gcc gcc-4.9.3: error: converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null] ash/display/json_converter_unittest.cc chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp BUG=461205 R=darin@chromium.org TEST= is_clang=false && ninja -C out/build all CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/89d6af1e4ddfd34be8aeddbc8194f91504484d4d Cr-Commit-Position: refs/heads/master@{#396312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ash/display/json_converter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/ordered_simple_task_runner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013573003/1
4 years, 7 months ago (2016-05-25 09:53:09 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 11:48:26 UTC) #5
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 11:48:31 UTC) #6
Julien Isorce Samsung
On 2016/05/25 11:48:26, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 7 months ago (2016-05-26 16:46:13 UTC) #9
Ben Goodger (Google)
lgtm
4 years, 7 months ago (2016-05-26 16:48:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013573003/1
4 years, 7 months ago (2016-05-26 20:52:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 23:22:47 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 23:23:59 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89d6af1e4ddfd34be8aeddbc8194f91504484d4d
Cr-Commit-Position: refs/heads/master@{#396312}

Powered by Google App Engine
This is Rietveld 408576698